Drupal 9 Deprecated Code Report [#3042837]

Problem/Motivation

drupal-check results on commit hash:
source : [git] https://git.drupal.org/project/eck ecf376114716c9174615534fb42c47bf596f1f17
source : http://git.drupal.org/project/eck.git

Errors


 ------ ----------------------------------------------- 
  Line   src/Controller/EckEntityBundleListBuilder.php  
 ------ ----------------------------------------------- 
  75     Call to deprecated method getLabel() of class  
         Drupal\Core\Entity\EntityListBuilder.          
 ------ ----------------------------------------------- 

 ------ --------------------------------------------- 
  Line   src/Entity/EckEntityType.php                 
 ------ --------------------------------------------- 
  98     Call to deprecated method link() of class    
         Drupal\Core\Config\Entity\ConfigEntityBase.  
 ------ --------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   tests/src/Unit/UnitTestBase.php                    
 ------ --------------------------------------------------- 
  89     Fetching class constant class of deprecated class  
         Drupal\Core\Entity\EntityManagerInterface.         
 ------ --------------------------------------------------- 

 [ERROR] Found 3 errors

Warnings


 ------ ----------------------------------------------- 
  Line     eck.install
 ------ ----------------------------------------------- 
  32       Call to deprecated method applyUpdates() of class 
         Drupal\Core\Entity\EntityDefinitionUpdateManagerInterface.
 ------ ----------------------------------------------- 

 ------ --------------------------------------------- 
  Line     eck.install             
 ------ --------------------------------------------- 
  51       Call to deprecated method applyUpdates() of class    
         Drupal\Core\Entity\EntityDefinitionUpdateManagerInterface  
 ------ --------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   src/Entity/EckEntityType.php                    
 ------ --------------------------------------------------- 
  121     Call to deprecated method applyUpdates() of class  
          Drupal\Core\Entity\EntityDefinitionUpdateManagerInterface         
 ------ --------------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   src/Form/EntityType/EckEntityTypeEditForm.php              
 ------ --------------------------------------------------- 
  34      Call to deprecated method getFieldStorageDefinitions() of class 
          Drupal\Core\Entity\Sql\SqlContentEntityStorage         
 ------ --------------------------------------------------- 

 [WARNING] Found 4 warnings

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comment	File	Size	Author
#15	interdiff_8-15.txt	1.45 KB	andralex
#15	eck-3042837-15.patch	2.33 KB	andralex
#15	8.x-1.x: PHP 7.2 & MySQL 5.5, D8.9 65 pass
#14	interdiff_8-14.txt	1.41 KB	andralex
#14	eck-3042837-14.patch	2.37 KB	andralex
#14	8.x-1.x: PHP 7.2 & MySQL 5.5, D8.9 Patch Failed to Apply
#12	interdiff_8-12.txt	1.77 KB	andralex
#12	eck-3042837-12.patch	3.29 KB	andralex
#12	8.x-1.x: PHP 7.2 & MySQL 5.5, D8.9 61 pass, 2 fail
#11	eck-3042837-11.patch	360 bytes	Tolyan4ik
#11	8.x-1.x: PHP 7.2 & MySQL 5.5, D8.9 65 pass
#8	interdiff-3042837-2-8.txt	1004 bytes	-enzo-
#8	eck-3042837-8.patch	1.88 KB	-enzo-
#8	8.x-1.x: PHP 7.2 & MySQL 5.5, D8.9 28 pass, 14 fail
#2	eck-3042837-2.patch	1.87 KB	jigish.addweb
#2	8.x-1.x: PHP 7.2 & MySQL 5.5, D8.8 Build Successful

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

24 March 2019 at 00:43

mcdwayne created an issue. See original summary.

Comment #2

jigish.addweb CreditAttribution: jigish.addweb at AddWeb Solution Pvt. Ltd. commented 14 May 2019 at 13:01

Status:

Active

» Needs review

File	Size
eck-3042837-2.patch	1.87 KB
8.x-1.x: PHP 7.2 & MySQL 5.5, D8.8 Build Successful

@mcdwayne, As per your above-mentioned requirement, I attached a patch for the same. Kindly review the attachment and feel free to share & discuss your views.

Thanks!

Comment #3

oknate

Greater New York City Area

CreditAttribution: oknate as a volunteer and commented 14 May 2019 at 13:06

It looks like you're missing a use statement here:
I think you need to add a use statement at the top of the file for EntityTypeManagerInterface.

diff --git a/tests/src/Unit/UnitTestBase.php b/tests/src/Unit/UnitTestBase.php
index ea5031b..7b73119 100644
--- a/tests/src/Unit/UnitTestBase.php
+++ b/tests/src/Unit/UnitTestBase.php
@@ -86,7 +86,7 @@ namespace Drupal\Tests\eck\Unit {
       $entity_storage = $this->getEntityStorageMock();
       $definition = $this->getMockForAbstractClass(EntityTypeInterface::class);
 
-      $entity_manager = $this->getMockForAbstractClass(EntityManagerInterface::class);
+      $entity_manager = $this->getMockForAbstractClass(EntityTypeManagerInterface::class);
       $entity_manager->method('getStorage')->willReturn($entity_storage);
       $entity_manager->method('getDefinition')->willReturn($definition);

Comment #4

14 May 2019 at 13:10

Status:

Needs review

» Needs work

The last submitted patch, 2: eck-3042837-2.patch, failed testing. View results

Comment #5

14 May 2019 at 13:10

Status:

Needs review

» Needs work

The last submitted patch, 2: eck-3042837-2.patch, failed testing. View results

Comment #6

sim_1

she/her

CreditAttribution: sim_1 as a volunteer commented 3 July 2019 at 19:18

Issue summary:

View changes

Updating issue description with warnings from the latest code that includes deprecated code from D8.7.

Comment #7

sim_1

she/her

CreditAttribution: sim_1 as a volunteer commented 3 July 2019 at 19:53

Also, I'll add a note confirming that the patch resolves all of the errors. The only remaining issues are warnings.

Comment #8

-enzo- CreditAttribution: -enzo- at weKnow Inc commented 13 November 2019 at 03:19

File	Size
eck-3042837-8.patch	1.88 KB
8.x-1.x: PHP 7.2 & MySQL 5.5, D8.9 28 pass, 14 fail
interdiff-3042837-2-8.txt	1004 bytes

Hi folks

I re-use the part of patch #2, and some other changes and according with drupal-check all looks ok, please check

Comment #9

-enzo- CreditAttribution: -enzo- at weKnow Inc commented 13 November 2019 at 03:19

Status:

Needs work

» Needs review

Comment #10

Tolyan4ik CreditAttribution: Tolyan4ik at EPAM Systems commented 13 February 2020 at 09:55

Status:

Needs review

» Needs work

Need to add "core_version_requirement: ^8 || ^9" to info.yml file

Comment #11

Tolyan4ik CreditAttribution: Tolyan4ik at EPAM Systems commented 13 February 2020 at 10:00

Status:

Needs work

» Needs review

File	Size
eck-3042837-11.patch	360 bytes
8.x-1.x: PHP 7.2 & MySQL 5.5, D8.9 65 pass

Comment #12

andralex CreditAttribution: andralex at EPAM Systems for EPAM Systems commented 14 February 2020 at 15:57

File	Size
eck-3042837-12.patch	3.29 KB
8.x-1.x: PHP 7.2 & MySQL 5.5, D8.9 61 pass, 2 fail
interdiff_8-12.txt	1.77 KB

4 files were hidden/shown/deleted

File	Size
eck-3042837-2.patch	1.87 KB
8.x-1.x: PHP 7.2 & MySQL 5.5, D8.8 Build Successful
eck-3042837-8.patch	1.88 KB
8.x-1.x: PHP 7.2 & MySQL 5.5, D8.9 28 pass, 14 fail
interdiff-3042837-2-8.txt	1004 bytes
eck-3042837-11.patch	360 bytes
8.x-1.x: PHP 7.2 & MySQL 5.5, D8.9 65 pass

Combined #8 and #11 patches into one. Fixed

Call to undefined method

from failed tests.

Comment #13

14 February 2020 at 16:03

Status:

Needs review

» Needs work

The last submitted patch, 12: eck-3042837-12.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Comment #14

andralex CreditAttribution: andralex at EPAM Systems for EPAM Systems commented 14 February 2020 at 17:11

Status:	Needs work	» Needs review
Issue tags:		+deprecated

File	Size
eck-3042837-14.patch	2.37 KB
8.x-1.x: PHP 7.2 & MySQL 5.5, D8.9 Patch Failed to Apply
interdiff_8-14.txt	1.41 KB

2 files were hidden/shown/deleted

File	Size
eck-3042837-12.patch	3.29 KB
8.x-1.x: PHP 7.2 & MySQL 5.5, D8.9 61 pass, 2 fail
interdiff_8-12.txt	1.77 KB

Should fix failed test. Added codesniffer fixes.

Comment #15

andralex CreditAttribution: andralex at EPAM Systems for EPAM Systems commented 14 February 2020 at 17:27

File	Size
eck-3042837-15.patch	2.33 KB
8.x-1.x: PHP 7.2 & MySQL 5.5, D8.9 65 pass
interdiff_8-15.txt	1.45 KB

2 files were hidden/shown/deleted

File	Size
eck-3042837-14.patch	2.37 KB
8.x-1.x: PHP 7.2 & MySQL 5.5, D8.9 Patch Failed to Apply
interdiff_8-14.txt	1.41 KB

Sorry guys. One more try. It should work now.

Comment #16

alex_optim

🇺🇦 Rivne

CreditAttribution: alex_optim at GOLEMS GABB, Drupal Ukraine Community for GOLEMS GABB, Drupal Ukraine Community commented 1 March 2020 at 21:52

Status:

Needs review

» Reviewed & tested by the community

Good work.

Comment #17

pifagor

🇺🇦 Rivne

CreditAttribution: pifagor at EPAM Systems, Drupal Ukraine Community for EPAM Systems, Drupal Ukraine Community commented 1 March 2020 at 22:47

Comment #18

1 March 2020 at 22:47

pifagor committed e1d4452 on 8.x-1.x authored by andralex

Issue #3042837 by andralex, -enzo-, Tolyan4ik, jigish.addweb, sim_1,...

Comment #19

pifagor

🇺🇦 Rivne

CreditAttribution: pifagor at EPAM Systems, Drupal Ukraine Community for EPAM Systems, Drupal Ukraine Community commented 1 March 2020 at 22:48

Status:

Reviewed & tested by the community

» Fixed

Comment #20

15 March 2020 at 22:49

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Drupal 9 Deprecated Code Report

Problem/Motivation

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comments

Comment #1

Comment #2

Comment #3

Comment #4

Comment #5

Comment #6

Comment #7

Comment #8

Comment #9

Comment #10

Comment #11

Comment #12

Comment #13

Comment #14

Comment #15

Comment #16

Comment #17

Comment #18

Comment #19

Comment #20

Thank you to these Drupal contributors

News items

Our community

Documentation

Drupal code base

Governance of community