Problem/Motivation

drupal-check results on commit hash: 74c9ba8668f8ad00232979fdb2e89ff2af4c69d2


 ------ ------------------------------------------------------------------------------------------ 
  Line   tests/src/FunctionalJavascript/InfiniteScrollTest.php                                     
 ------ ------------------------------------------------------------------------------------------ 
  15     Class Drupal\Tests\views_infinite_scroll\FunctionalJavascript\InfiniteScrollTest extends  
         deprecated class Drupal\FunctionalJavascriptTests\JavascriptTestBase.                     
  17     Usage of deprecated trait Drupal\simpletest\NodeCreationTrait in class                    
         Drupal\Tests\views_infinite_scroll\FunctionalJavascript\InfiniteScrollTest.               
  18     Usage of deprecated trait Drupal\simpletest\ContentTypeCreationTrait in class             
         Drupal\Tests\views_infinite_scroll\FunctionalJavascript\InfiniteScrollTest.               
  39     Call to method setUp() of deprecated class Drupal\Tests\BrowserTestBase.                  
 ------ ------------------------------------------------------------------------------------------ 

 [ERROR] Found 4 errors

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#3 Screen Shot 2019-04-26 at 5.07.08 PM.png18.05 KBvolkswagenchick
#2 drupal_9_deprecated_code-3042629-2.patch970 bytessergiu stici

Comments

ChaseOnTheWeb created an issue. See original summary.

sergiu stici’s picture

sergiu stici commented
Status: Active » Needs review
StatusFileSize
new drupal_9_deprecated_code-3042629-2.patch970 bytes

Here is the patch, please review.

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screen Shot 2019-04-26 at 5.07.08 PM.png18.05 KB

Confirming before patch I received the following errors
------ -----------------------------------------------------------------------------------------------------------
Line tests/src/FunctionalJavascript/InfiniteScrollTest.php
------ -----------------------------------------------------------------------------------------------------------
15 Class Drupal\Tests\views_infinite_scroll\FunctionalJavascript\InfiniteScrollTest extends deprecated class
Drupal\FunctionalJavascriptTests\JavascriptTestBase.
17 Usage of deprecated trait Drupal\simpletest\NodeCreationTrait in class
Drupal\Tests\views_infinite_scroll\FunctionalJavascript\InfiniteScrollTest.
18 Usage of deprecated trait Drupal\simpletest\ContentTypeCreationTrait in class
Drupal\Tests\views_infinite_scroll\FunctionalJavascript\InfiniteScrollTest.
39 Call to method setUp() of deprecated class Drupal\Tests\BrowserTestBase.
------ -----------------------------------------------------------------------------------------------------------

patch applied locally.
AFter applying the patch:
The were no errors. Screenshot attached. Marking RTBC

  • Sergiu Stici authored 1ebd935 on 8.x-1.x 
    Issue #3042629 by Sergiu Stici, volkswagenchick: Drupal 9 Deprecated...
honza pobořil’s picture

honza pobořil commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.