The way the JS has been written implies a dependency on the bartik theme.

I have identified two problems, maybe there are more:
- You need the block template because it adds a "content" class that is used to refresh the inbox block.

<div{{ content_attributes.addClass('content') }}>

- The position of the blocks in the page matters. It is not possible to put the inbox block before the content because of a JS selector.
The code should not be based on the use of ":first".

threadWrapper = $(".private-message-thread").parent();

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

phjou created an issue. See original summary.

phjou’s picture

Issue summary: View changes
phjou’s picture

Priority: Normal » Critical
Issue summary: View changes

Since you can use this module with only one theme (or if you spend time to debug like and find out what templates you need), I think this is pretty critical.

phjou’s picture

Issue summary: View changes
phjou’s picture

Just added this issue related #3038271 Inbox not working properly
The second problem is basically this issue. There is a fix that is needed quickly, but I think it will still be theme dependent.

The selector "$(".private-message-thread-full")" will not be there in every theme. We have to use selectors with a naming like "js-class-name" in order to work with every theme and it will split properly the JS logic and the templating.

phjou’s picture

Title: Dependency on bartik » Dependency on bartik in the JS

Change name of the issue to be distinct from #3073058

snig made their first commit to this issue’s fork.

snig’s picture

Status: Active » Needs review
Issue tags: +LutskCodeSprint2021

Simple wrapping block content and changed class selector in js should fix this issue.

artem_sylchuk made their first commit to this issue’s fork.

artem_sylchuk’s picture

Status: Needs review » Fixed

Looks good enough for me.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.