On a Drupal 7 website running on PHP 7.3.1 it's giving:

"continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? field_tools.module:359
CommentFileSizeAuthor
#2 field_tools-php-7.3-compatibility-3041193-2.patch783 bytesnickonom

Comments

nickonom created an issue. See original summary.

nickonom’s picture

nickonom commented
Status: Active » Needs review
StatusFileSize
new field_tools-php-7.3-compatibility-3041193-2.patch783 bytes

Here is a patch file that fixes the issue.

Anonymous’s picture

Anonymous (not verified) commented

+1 for this

I tried it locally and it removed the warning. It's such a minor thing that I'd be amazed anyway if it didn't work as expected.

ronino’s picture

ronino commented
Status: Needs review » Reviewed & tested by the community

Just works. Thanks.

joachim’s picture

joachim commented
Status: Reviewed & tested by the community » Needs work

Patch isn't applying.

jacob.embree’s picture

jacob.embree commented
Status: Needs work » Reviewed & tested by the community
Issue tags: +PHP 7.3

Are you sure you're applying it against 7.x-1.x? It applies for me.

  • joachim committed 29d1d81 on 7.x-1.x authored by nickonom 
    Issue #3041193 by nickonom: Updated for compatibility with PHP 7.3.
joachim’s picture

joachim commented
Status: Reviewed & tested by the community » Fixed

Oops, I was on the D8 branch!!

Thanks everyone! Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.