CommentFileSizeAuthor
#4 address-best-practice-3037924-2.patch3.82 KBnitin.ahire
#2 address-best-practice-3037924-1.patch8.51 KBnitin.ahire

Comments

nitin.ahire created an issue. See original summary.

nitin.ahire’s picture

nitin.ahire commented
StatusFileSize
new address-best-practice-3037924-1.patch8.51 KB

Status: Needs review » Needs work

The last submitted patch, 2: address-best-practice-3037924-1.patch, failed testing. View results

nitin.ahire’s picture

nitin.ahire commented
StatusFileSize
new address-best-practice-3037924-2.patch3.82 KB
nitin.ahire’s picture

nitin.ahire commented
Status: Needs work » Needs review
nitin.ahire’s picture

nitin.ahire commented
amit.drupal’s picture

amit.drupal commented
Status: Needs review » Reviewed & tested by the community

This is looking great, thanks for the patch!
I think you forget some other file for Replace t() with $this->t().

List some files:
address/address.install
address/address.post_update.php
address/address.tokens.inc
address/src/Element/Address.php
address/src/Element/Zone.php
address/src/Element/ZoneTerritory.php

  • bojanz committed 669c21a on 8.x-1.x authored by nitin.ahire 
    Issue #3037924 by nitin.ahire: Replace t() with $this->t() as a best...
bojanz’s picture

bojanz commented
Status: Reviewed & tested by the community » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.