Problem/Motivation

Deprecated Unicode::substr() need to be replaced

Proposed resolution

Use mb_substr()

Change records: https://www.drupal.org/node/2850048

CommentFileSizeAuthor
#10 3035119-replace-unicode-substr.patch5.71 KBdave reid
#9 3035119-replace-unicode-substr.patch5.79 KBdave reid
#6 xmlsitemap-Use_mb_functions_instead_of_Unicode::_methods-3035119-6-D8.patch4.34 KBthalles
#4 xmlsitemap-Use_mb_functions_instead_of_Unicode::_methods-3035119-4-D8.patch3.71 KBthalles
#2 xmlsitemap-Use_mb_functions_instead_of_Unicode::_methods-3035119-2-D8.patch14.83 KBthalles

Comments

thalles created an issue. See original summary.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Title: Deprecated Unicode::substr() need to be replaced » Use mb_* functions instead of Unicode::* methods
StatusFileSize
new xmlsitemap-Use_mb_functions_instead_of_Unicode::_methods-3035119-2-D8.patch14.83 KB

Follow the patch!

Status: Needs review » Needs work

The last submitted patch, 2: xmlsitemap-Use_mb_functions_instead_of_Unicode::_methods-3035119-2-D8.patch, failed testing. View results

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Needs work » Needs review
StatusFileSize
new xmlsitemap-Use_mb_functions_instead_of_Unicode::_methods-3035119-4-D8.patch3.71 KB

Follow the patch!

Status: Needs review » Needs work

The last submitted patch, 4: xmlsitemap-Use_mb_functions_instead_of_Unicode::_methods-3035119-4-D8.patch, failed testing. View results

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Needs work » Needs review
StatusFileSize
new xmlsitemap-Use_mb_functions_instead_of_Unicode::_methods-3035119-6-D8.patch4.34 KB

Follow the patch!

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Closed (duplicate)
Parent issue: #3034169: Deprecated strtolower need to be replaced »
Related issues: +#3034169: Deprecated strtolower need to be replaced

This is a duplicate of #3034169: Deprecated strtolower need to be replaced

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Closed (duplicate) » Needs review

My apologies, this is about substr not strtolower, re-opening.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
StatusFileSize
new 3035119-replace-unicode-substr.patch5.79 KB

This can actually just be replaced by a much simpler substr(), I'm not sure why it needed to use the unicode functions. This also cleans up a couple more deprecated things in the same classes.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
StatusFileSize
new 3035119-replace-unicode-substr.patch5.71 KB

With some cleaned up use statements as well.

  • Dave Reid committed 2ddf03f on 8.x-1.x 
    Issue #3035119 by thalles, Dave Reid: Use strpos() instead of deprecated...
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Fixed

Committed #10 to 8.x-1.x.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented

Thanks Dave!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.