There is an issue when using CSV parser with option No headers when mapping a column 0.
The column could be configured and mapped in UI but during CSV parsing it will be skipped due to wrong PHP condition of mapping source.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | feeds-mapping-source-0-not-working-3034101-7.patch | 4.73 KB | megachriz |
| #7 | feeds-mapping-source-0-not-working-3034101-7-tests-only.patch | 4.22 KB | megachriz |
| #2 | mapping-source-0-not-working-3034101-1.patch | 521 bytes | tomasbarej |
Comments
Comment #2
tomasbarej commentedComment #3
megachrizThanks for the patch. An automated test that demonstrates the bug would be useful as well. Do you want to write that?
Comment #4
fonant commentedThe first column is not read if the CSV has a heading row, too.
Comment #5
megachriz@tomasbarej
I have been trying to write a test for this case, but wasn't able to reproduce the exact issue. The fix looks alright, but I want to make sure that the bug does not return in the future, hence the need for a test. Can you provide the exact steps to reproduce the issue?
Comment #6
megachrizOops, disregard @tomasbarej. Wrong issue! Comment was meant for #3042062: Node access prevent Feeds from updating existing (unpublished) content.
Tests would be useful here too, nonetheless.
Comment #7
megachrizNow with an unit test.
Comment #10
megachrizCommitted #7.