There is an issue when using CSV parser with option No headers when mapping a column 0.

The column could be configured and mapped in UI but during CSV parsing it will be skipped due to wrong PHP condition of mapping source.

CommentFileSizeAuthor
#7 feeds-mapping-source-0-not-working-3034101-7.patch4.73 KBmegachriz
#7 feeds-mapping-source-0-not-working-3034101-7-tests-only.patch4.22 KBmegachriz
#2 mapping-source-0-not-working-3034101-1.patch521 bytestomasbarej

Comments

tomasbarej created an issue. See original summary.

tomasbarej’s picture

tomasbarej commented
StatusFileSize
new mapping-source-0-not-working-3034101-1.patch521 bytes
megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Needs review » Active
Issue tags: +Needs tests

Thanks for the patch. An automated test that demonstrates the bug would be useful as well. Do you want to write that?

fonant’s picture

fonant commented

The first column is not read if the CSV has a heading row, too.

megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Active » Needs work

@tomasbarej
I have been trying to write a test for this case, but wasn't able to reproduce the exact issue. The fix looks alright, but I want to make sure that the bug does not return in the future, hence the need for a test. Can you provide the exact steps to reproduce the issue?

megachriz’s picture

megachriz
Primary language Dutch
commented

Oops, disregard @tomasbarej. Wrong issue! Comment was meant for #3042062: Node access prevent Feeds from updating existing (unpublished) content.

Tests would be useful here too, nonetheless.

megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Needs work » Needs review
StatusFileSize
new feeds-mapping-source-0-not-working-3034101-7-tests-only.patch4.22 KB
new feeds-mapping-source-0-not-working-3034101-7.patch4.73 KB

Now with an unit test.

The last submitted patch, 7: feeds-mapping-source-0-not-working-3034101-7-tests-only.patch, failed testing. View results

  • MegaChriz committed fd19474 on 8.x-3.x authored by tomasbarej 
    Issue #3034101 by MegaChriz, tomasbarej: Fixed mapping source 0 not...
megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Needs review » Fixed
Issue tags: -Needs tests

Committed #7.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.