PanelizerWizardContextForm calls parent constructor without enough arguments under CTools 3.1

I second this and I was about to post the same issue with a nearly identical patch. The only difference between the way I patched it and and the way @phenaproxima did was that I made the TypedDataResolver the fourth argument instead of the third of the __construct() operation. The only reason I bring this up is that I'm interested in knowing if there's a best practice for how to add a new argument in cases like this.

I added it as the 4th argument just in case there was something extending the PanelizerWizardContextForm class and was providing the SharedTempStoreFactory object as the third argument, the change wouldn't break anything.

There isn't anything in the contrib codebase that I know of that is extending PanelizerWizardContextForm so this is just an academic question.

Hi all,

Adding Drupal\Core\TempStore\SharedTempStoreFactory correction on file src/Plugin/PanelsPattern/PanelizerPattern.php to the patch.

Corrects error:

 Fatal error: Declaration of Drupal\panelizer\Plugin\PanelsPattern\PanelizerPattern::getDefaultContexts(Drupal\user\SharedTempStoreFactory $tempstore, $tempstore_id, $machine_name) must be compatible with Drupal\panels\Plugin\PanelsPattern\DefaultPattern::getDefaultContexts(Drupal\Core\TempStore\SharedTempStoreFactory $tempstore, $tempstore_id, $machine_name) in /home/vagrant/code/nos-medicos-do-mundo/site/web/modules/contrib/panelizer/src/Plugin/PanelsPattern/PanelizerPattern.php on line 14

on page /admin/structure/panelizer/edit/node_<node-type>_<view-mode>_<display>/content

#8 works for me

#8 Fixed my issues

Dropping by to confirm that patch #8 fixes the problem for me as well -- many thanks!!

#8 works for me also

Hi,

I've implemented the patch, and I see that it seems solves the problem.
However, unfortunately, I've discovered another problem.

I couldn't save the Panel via IPE afterward, here's the error that I got from dblog:

Drupal\Component\Plugin\Exception\PluginNotFoundException: The "" entity type does not exist. in Drupal\Core\Entity\EntityTypeManager->getDefinition() (line 150 of /Users/ardiiepl/Documents/Works/money-site_docker/money-site/core/lib/Drupal/Core/Entity/EntityTypeManager.php).

The problem still persist even after I implemented this patch https://www.drupal.org/files/issues/2874489-12.patch from here: https://www.drupal.org/node/2874489

I haven't debug further again though.
I hope someone can shed me some light on this.

Thanks in advance!

Hi,

I have Fixed this issue and created a patch. Please review.

Thanks

Patch is good but test is failing need to fix those before moving to further.

Applying the patch in #15 fixes the issue of

Fatal error: Declaration of Drupal\panelizer\Plugin\PanelsPattern\PanelizerPattern::getDefaultContexts(Drupal\user\SharedTempStoreFactory $tempstore, $tempstore_id, $machine_name) must be compatible with Drupal\panels\Plugin\PanelsPattern\DefaultPattern::getDefaultContexts(Drupal\Core\TempStore\SharedTempStoreFactory $tempstore, $tempstore_id, $machine_name) in /var/www/xxxx/docroot/modules/contrib/panelizer/src/Plugin/PanelsPattern/PanelizerPattern.php on line 14

However accessing /admin/structure/panelizer/edit/node__landing_page__default__default/content?js=nojs and trying to clicking on 「+ Add new block」or Edit buttons on existing items does nothing.
Checking console shows below Ajax error:

An AJAX HTTP error occurred.
HTTP Result Code: 200
Debugging information follows.
Path: /en/admin/structure/panels/panelizer.wizard/node__landing_page__default__default/select_block?region&destination=/en/admin/structure/panelizer/edit/node__landing_page__default__default/content%3Fjs%3Dnojs
StatusText: OK
ResponseText: 
Error: Call to a member function getPattern() on null in Drupal\panels\Controller\Panels->selectBlock() 
(line 112 of /var/www/XXX/docroot/modules/contrib/panels/src/Controller/Panels.php).

There's a new version of Panelizer, 8.x-4.2, so I rerolled the patch to account for some changes in the new branch.

I made no changes to resolve the issues pointed out in #17.

@wylbur you attached twice $container->get('ctools.typed_data.resolver'), so your patch doesn't works.

Patch fails to apply to latest dev-4.x

www-data@5ee2206ee8df:/app/docroot$ composer update
    1/1:	http://repo.packagist.org/p/provider-latest$a6ae7825ccea794fcd6456116d31e6a63f90fb2054255e091e24888f03eefadb.json
    Finished: success: 1, skipped: 0, failure: 0, total: 1
Gathering patches for root package.
Loading composer repositories with package information
Updating dependencies (including require-dev)         
Package operations: 2 installs, 0 updates, 0 removals
Gathering patches for root package.
Gathering patches for dependencies. This might take a minute.
  - Installing drupal/panelizer (dev-4.x 0ad3608): Cloning 0ad3608074 from cache
  - Applying patches for drupal/panelizer
    https://www.drupal.org/files/issues/2020-03-25/3031671-SharedTempStoreFactory-22.patch (Change panelizer store)
   Could not apply patch! Skipping. The error was: Cannot apply patch https://www.drupal.org/files/issues/2020-03-25/3031671-SharedTempStoreFactory-22.patch

For me this issue is resolved right now. Please check the latest version of module.

lgtm