A few of fields for editing on https://www.drupal.org/node/add/sa are in a different order than when they are displayed, e.g. on https://www.drupal.org/sa-contrib-2019-004

Specifically
* Adding/editing the "Description" and "Solution" fields come at the end of the list (after Reported by, Fixed by, Coordinated by)
* When viewing, Reported by, Fixed by, Coordinated by come before the "Description" and "Solution" fields
* The order of the fields in viewing is the same as they are presented on s.d.o

It would be easier to copy and paste the advisory from s.d.o to d.o if the fields were in the same order when editing (with Description and Solution before Reported by).

Comments

greggles created an issue. See original summary.

drumm’s picture

drumm
he/him
Location NY, US
commented
Component: Code » Security advisories
Parent issue: » #2969694: Streamline SA publishing
drumm’s picture

drumm
he/him
Location NY, US
commented
Assigned: Unassigned » drumm

  • drumm committed 01850ebb on 7.x-3.x 
    Issue #3031118: Adjust order for editing SA fields to match the display...
drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Active » Fixed
greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Fixed » Needs work

This got kinda fixed so that s.d.o matched the order on d.o so maybe we need a followup to re-adjust the order on s.d.o to match what this is?

drumm’s picture

drumm
he/him
Location NY, US
commented

Sure, we can do that. Is the order on Drupal.org looking good now?

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

Not quite.

d.o:
Project
Version dropdown
Affected versions composer thing
Security risk score
Vulnerability
Description
Solution
Reported by
Fixed by
Coordinated by

s.d.o:
(missing) project
(too high) vulnerability
(too low) version
security risk
reported by
fixed by
coordinated by
(too low) description
(too low) solution

drumm’s picture

drumm
he/him
Location NY, US
commented
Project: Drupal.org customizations » Drupal Security Team
Version: 7.x-3.x-dev » 7.x-1.x-dev
Component: Security advisories » sahtml

I'll update the order on security.drupal.org to match Drupal.org.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

That seems great. Thank you!

drumm’s picture

drumm
he/him
Location NY, US
commented

The field order is adjusted, that needs to be exported, once reviewed. And the HTML version tab still needs reordering.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

Oooh, I probably should have said the place where field order on s.d.o is really important is on the /html view, e.g. https://security.drupal.org/node/177243/html

  • drumm committed d9cf852a on 7.x-1.x 
    Issue #3031118 by drumm, greggles: Adjust order for editing SA fields to...
drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Needs work » Needs review

I believe the field orders should be in sync everywhere now.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

Perfect, thank you!

drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.