Problem/Motivation

In case of an entity with an entity reference field containing the entity itself, the entity is cloned three times.

Step to reproduce

With standard installation:

  • Add an entity reference field to the article content type
  • Create a new article
  • Save
  • Edit the article
  • Reference the article itself in the entity reference field
  • Save
  • Clone

The content is cloned three times:

  • 2 with "- cloned" label
  • 1 without "- cloned" label
CommentFileSizeAuthor
#19 entity-clone-avoid-update-title-twice-from-unwanted-redirect-3030806-19.patch1.04 KBvishnutrz
#11 3030806-11-entity-with-direct-circular-reference-is-cloned-three-times.patch22.24 KBvpeltot
#10 3030806-10-entity-with-direct-circular-reference-is-cloned-three-times.patch22.44 KBvpeltot
#9 3030806-9-entity-with-direct-circular-reference-is-cloned-three-times.patch22.45 KBvpeltot
#8 interdiff_3030806-2-8.txt9.42 KBvpeltot
#8 3030806-8-entity-with-direct-circular-reference-is-cloned-three-times.patch15.52 KBvpeltot
#6 interdiff_3030806-2-6.txt9.35 KBvpeltot
#6 3030806-6-entity-with-direct-circular-reference-is-cloned-three-times.patch15.45 KBvpeltot
#4 interdiff_3030806-2-4.txt9.61 KBvpeltot
#4 3030806-4-entity-with-direct-circular-reference-is-cloned-three-times.patch15.71 KBvpeltot
#2 3030806-2-entity-with-direct-circular-reference-is-cloned-three-times.patch11.25 KBvpeltot

Comments

vpeltot created an issue. See original summary.

vpeltot’s picture

vpeltot commented
Status: Active » Needs review
StatusFileSize
new 3030806-2-entity-with-direct-circular-reference-is-cloned-three-times.patch11.25 KB

Here a patch to solve this.

  • Refine the form to add information in case of reference circular is detected
  • Force to use already cloned entity when an entity has a circular reference

Status: Needs review » Needs work

The last submitted patch, 2: 3030806-2-entity-with-direct-circular-reference-is-cloned-three-times.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

vpeltot’s picture

vpeltot commented
Status: Needs work » Needs review
StatusFileSize
new 3030806-4-entity-with-direct-circular-reference-is-cloned-three-times.patch15.71 KB
new interdiff_3030806-2-4.txt9.61 KB

Status: Needs review » Needs work

The last submitted patch, 4: 3030806-4-entity-with-direct-circular-reference-is-cloned-three-times.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

vpeltot’s picture

vpeltot commented
Status: Needs work » Needs review
StatusFileSize
new 3030806-6-entity-with-direct-circular-reference-is-cloned-three-times.patch15.45 KB
new interdiff_3030806-2-6.txt9.35 KB

Status: Needs review » Needs work

The last submitted patch, 6: 3030806-6-entity-with-direct-circular-reference-is-cloned-three-times.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

vpeltot’s picture

vpeltot commented
Status: Needs work » Needs review
StatusFileSize
new 3030806-8-entity-with-direct-circular-reference-is-cloned-three-times.patch15.52 KB
new interdiff_3030806-2-8.txt9.42 KB
vpeltot’s picture

vpeltot commented
StatusFileSize
new 3030806-9-entity-with-direct-circular-reference-is-cloned-three-times.patch22.45 KB

Add tests to cover this issue.

vpeltot’s picture

vpeltot commented
StatusFileSize
new 3030806-10-entity-with-direct-circular-reference-is-cloned-three-times.patch22.44 KB

Re-roll

vpeltot’s picture

vpeltot commented
StatusFileSize
new 3030806-11-entity-with-direct-circular-reference-is-cloned-three-times.patch22.24 KB

The same patch with coding standards issues fixed.

mars0test’s picture

mars0test commented

RTBC
After testing all seems good for me !

mars0test’s picture

mars0test commented
Status: Needs review » Reviewed & tested by the community

  • vpeltot committed 3104669 on 8.x-1.x 
    Issue #3030806 by vpeltot: Entity with direct circular reference is...
vpeltot’s picture

vpeltot commented
Status: Reviewed & tested by the community » Fixed

Commited !

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

dksdev01’s picture

dksdev01 commented

Looks after this change, hook_entity_presave is being called twice on every clone. thanks

akalam’s picture

akalam commented

This change is also causing a unneeded redirect whenever you clone a node if you have installed the redirect module and configured in "automatic" mode.

Is really needed to save the cloned entity twice? Maybe we can add the cloned entity to the $already_cloned as a reference.

vishnutrz’s picture

vishnutrz commented
StatusFileSize
new entity-clone-avoid-update-title-twice-from-unwanted-redirect-3030806-19.patch1.04 KB

When we have entity clone module and redirect module with "Automatically create redirects when URL aliases are changed" enable. We can see unwanted redirect create when clone the node due to update in the label "- cloned" on save the entity second time.

We can avoid this by change the label at initial entity save itself.

Attached is a simple patch that fixes this.