Just looking at theme_shortcode_video_embed_youtube(), I'm seeing that if the user sets both dimensions (height and width), the width still gets overridden to main the 4:3 aspect ratio.

Most videos nowadays are shot in 16:9, while older videos would still be in 4:3. But as it stands, it's not currently possible to embed 16:9 videos with the correct aspect ratio.

Will attach patch shortly to fix this.

CommentFileSizeAuthor
#2 aspect-ratio_3028070_2.patch336 byteskhaled.zaidan

Issue fork shortcode_video-3028070

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

khaled.zaidan created an issue. See original summary.

khaled.zaidan’s picture

khaled.zaidan commented
StatusFileSize
new aspect-ratio_3028070_2.patch336 bytes

Attached patch.

khaled.zaidan’s picture

khaled.zaidan commented
Status: Active » Needs review

denes.szabo made their first commit to this issue’s fork.

denes.szabo opened merge request !4

  • denes.szabo committed 1429120c on 3.0.x 
    bug: #3028070 Honor explicit width and height for both providers

Width...
denes.szabo’s picture

denes.szabo commented
Version: 7.x-1.x-dev » 3.0.0
Assigned: khaled.zaidan » denes.szabo
Status: Needs review » Fixed

Thank you for your contribution; in the next release, the width calculation will be fixed.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

denes.szabo’s picture

denes.szabo commented
Assigned: denes.szabo » Unassigned
Status: Fixed » Closed (fixed)