Closed (fixed)
Project:
Group
Version:
8.x-1.x-dev
Component:
Code
Priority:
Major
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
18 Jan 2019 at 15:34 UTC
Updated:
8 Mar 2019 at 12:09 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
kristiaanvandeneyndeCode's finished, turning this into a meta issue and adding smaller patches in child issues.
Comment #3
kristiaanvandeneyndeEverything went green! So now all we need is a change record for this meta issue.
A potential follow-up that is now possible is the altering of permissions by firing a "calculating group permissions" event from GroupPermissionCalculator.
Comment #4
kristiaanvandeneyndeComment #5
kristiaanvandeneyndeAttached is a final patch that cleans up the previous work.
Most notably, it moves away from using "magic arrays" to represents permissions per scope and actually introduces a CalculatedGroupPermissionsItem value object which represents an account's permissions within a given scope. This allowed for further simplifications in the permission checker, calculator, hash generator and context.
Will need a change record for the new API and for the hash generator refactoring (because BC, sadly).
Comment #7
kristiaanvandeneyndeWill write up change records after lunch and then this can be considered Fixed.
Comment #8
kristiaanvandeneynde