Sometimes for proper styling we need to add a class on the rows parent div. This div already has the "row" class but that is too generic, and overriding views-bootstrap-grid.html.twig template is my only option. So, let's provide a new Views settings for the Grid style.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | 0001-updating-parent-class-3024039.patch | 2.13 KB | pixiekat |
| #2 | parent-class-3024039.patch | 2.08 KB | gnikolovski |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
gnikolovskiComment #3
gnikolovskiComment #4
Anatoliy Vorobyov commentedPatch adding new class to row, but not to parent of rows.
So @gnikolovski please adjust description or add class to parent of rows - in this case to ".views-view-grid".
Comment #5
gnikolovskiComment #6
aburrows commentedAdd a condition if the class is empty. It might be better using the twig
attributes.addClass.Comment #7
pixiekatCame across this issue since I was having trouble with it too and had some problems running the patch against the latest 4.x branch so I updated it.
Comment #9
dehacker commentedHope to see this functionality added to the module.
Comment #10
tim corkerton commentedGreat, I love it. Does just what I need
Comment #11
shelaneComment #12
tguerineau commentedI've successfully tested the 0001-updating-parent-class-3024039.patch patch on my local environment with Drupal 10 and I can confirm it works as expected. Here's a brief rundown of what I did:
- I ran PHP_CodeSniffer using the Drupal standard on the updated ViewsBootstrapGrid.php file to ensure it conforms to Drupal's coding standards. The file passed without any errors.
- I tested the functionality in a Drupal 10 environment to ensure that the 'rows_parent_class_custom' field appears in the views UI, and that its value is added as a class to the parent of rows. Everything functioned correctly.
- Additionally, I inspected the changes in the .twig file and manually checked that it followed Twig's standards.
Comment #13
tguerineau commentedComment #16
anybody@aburrows any change to get this merged soon? Would be really helpful.
If you need Co-maintainer help, feel free to ping we, so our team is willing to support.
Thank you!
Comment #17
thomas.frobieter@anybody it's already included in the current 5.x beta
Comment #18
anybodyI can't see any commit message or merge here. Should it be closed fixed then @aburrows?
Comment #19
shelaneThe 5.4 branch and 5.5 branch are separate branches supporting different versions of Bootstrap. Even if this is fixed for 5.5 doesn't mean it's fixed for 5.4. @aburrows has been supporting the 5.4 branch, but if he's not available, I can take a look in a couple of weeks.
Comment #20
anybodyThanks for the clarification @shelane, I wasn't aware of that.
Comment #25
shelaneThis is not the same implementation that exists for the Bootstrap 5 version. I really don't want to add a third custom class option. The change made for this version is the parent of the row. For the Bootstrap 5 version, the custom class is applied directly to the row class. There are many means of achieving this goal. So, as far as this request is concerned, it is done as requested. The Bootstrap 5 version, you will have to use other means of applying to a parent row.