Problem/Motivation

If the sql database being used has a different timezone then set in drupal, then orders placed at 11PM can look to have occurred in the next day. Erratic problems happen.

Proposed resolution

When querring, set the timezone offset.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3023795.patch1.17 KBheddn

Comments

heddn created an issue. See original summary.

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Status: Active » Needs review
StatusFileSize
new 3023795.patch1.17 KB

Status: Needs review » Needs work

The last submitted patch, 2: 3023795.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

shabana.navas’s picture

shabana.navas commented

This is not an issue with the patch. Tests were broken to begin with. Patch here: https://www.drupal.org/project/commerce_reports/issues/3037336 should fix the broken tests and tests here will pass once that is merged into 8.x-1.x.

shabana.navas’s picture

shabana.navas commented
Status: Needs work » Needs review
quietone’s picture

quietone commented

Should this have a test using different timezones?

quietone’s picture

quietone commented
Status: Needs review » Needs work
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Perhaps a nice and friendly shop, which earns money with Drupal Commerce could be so nice to sponsor this feature...? ;)

leducdubleuet’s picture

leducdubleuet commented
Status: Needs work » Reviewed & tested by the community

I can confirm this little patch is working well to fix this issue!

Thanks!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

@leducdubleuet perhaps you could create a MR from that to speed up things for the maintainers?

leducdubleuet’s picture

leducdubleuet commented

Sorry but I will not be using this module after all, thank you.

  • jsacksick committed 151e93b2 on 8.x-1.x 
    Issue #3023795 by heddn: Timezone adjustments are not accounted for in...
jsacksick’s picture

jsacksick commented
Status: Reviewed & tested by the community » Fixed

Trusting the community on this, committed the patch from #2.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.