Closed (fixed)
Project:
Insert
Version:
8.x-2.x-dev
Component:
Code
Priority:
Minor
Category:
Task
Assigned:
Reporter:
Created:
29 Dec 2018 at 14:54 UTC
Updated:
12 Jan 2019 at 15:04 UTC
Jump to comment: Most recent
Currently, module weight is explicitly set in Insert and its sub-modules. Setting module weight is a legacy from the module's D7 version and actually does not seem to be required on the module's D8 version as there do not seem to be hooks that need to be processed in a particular order. Apart from that, setting module weight is done on installation only, which is not a solid solution.
Having the actual dependencies required per insert.info, should just be sufficient for Insert, while sub-modules can make use of hook_module_implements_alter() instead of setting module weight on installation.
Comments
Comment #3
snater commentedAll Insert tests pass, so it should be fine to have all that module weight setting on installation removed.