Capitalize the name of the module, because module names are proper nouns.
https://www.drupal.org/docs/8/creating-custom-modules/let-drupal-8-know-...
Patch to follow, thanks!

BTW - Cool module! Can't wait to try it out on a site and see how it can help our workflow.

CommentFileSizeAuthor
#3 Screen Shot 2018-11-30 at 10.06.35 AM.png50.26 KBalonaoneill
#2 build_hooks-3017290.patch412 bytesaimeerae

Comments

aimeerae created an issue. See original summary.

aimeerae’s picture

aimeerae
she/her
Primary language English
Location San Francisco, CA
commented
Status: Active » Needs review
StatusFileSize
new build_hooks-3017290.patch412 bytes

Added the patch for the module capitalization and a slight description change in the info.yml file. Thanks for your neat module!

alonaoneill’s picture

alonaoneill commented
Assigned: aimeerae » Unassigned
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screen Shot 2018-11-30 at 10.06.35 AM.png50.26 KB

Jesus, we weren’t sure which package to add this to so we kept your current “Custom”, but you may consider something else over time…
Code looks good, the name of the module is now capitalized on the Extend page. Screenshot provided."
Marking as RTBC
Thank you for working on the module!

jmolivas’s picture

jmolivas commented

@alonaoneill I used `Custom` since have no idea for a better Package name instead, ideas welcome

jmolivas’s picture

jmolivas commented
Status: Reviewed & tested by the community » Fixed

Patch merged and included on the latest release.

Thanks, @aimeerae and @alonaoneill

jmolivas’s picture

jmolivas commented
Status: Fixed » Closed (fixed)
vermario’s picture

vermario commented

In the 2.x version of the module I have added "Build hooks" as the package, since we are including one submodule.