Problem/Motivation

Create the ability to provide notes for node types

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#18 3015665-node-type-7.patch3.05 KBlarowlan
#15 3015665-node-type-6.patch2.86 KBlarowlan
#13 3015665-node-type-5.patch2.82 KBlarowlan
#12 3015665-node-type-4.patch2.83 KBlarowlan
#9 3015665-node-type-3.patch2.83 KBlarowlan
#8 3015665-node-type-2.patch2.25 KBlarowlan
#7 3015665-node-type.patch1.83 KBlarowlan
#2 3015665-1.patch437 bytespasan.gamage

Comments

larowlan created an issue. See original summary.

pasan.gamage’s picture

pasan.gamage commented
Issue summary: View changes
StatusFileSize
new 3015665-1.patch437 bytes
pasan.gamage’s picture

pasan.gamage commented
Status: Active » Needs review
eric115’s picture

eric115 commented
Status: Needs review » Needs work

We need to update the builders notes schema file as well with:

node.type.*.third_party.builder_notes:
  type: builder_notes.notes

We will also need to update the tests as after saving a content type page it goes to the content types listing page, not back to the same page. This causes the final assertion of the builder notes to fail in assertNotesField().

pasan.gamage’s picture

pasan.gamage commented
Title: Add support for filter formats » Add support for node-types

Changed the title

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Issue tags: +Needs tests

Need to add a test too

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs work » Needs review
Issue tags: -Needs tests
StatusFileSize
new 3015665-node-type.patch1.83 KB
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
StatusFileSize
new 3015665-node-type-2.patch2.25 KB
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
StatusFileSize
new 3015665-node-type-3.patch2.83 KB

The last submitted patch, 7: 3015665-node-type.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Status: Needs review » Needs work

The last submitted patch, 9: 3015665-node-type-3.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs work » Needs review
StatusFileSize
new 3015665-node-type-4.patch2.83 KB
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
StatusFileSize
new 3015665-node-type-5.patch2.82 KB

The last submitted patch, 12: 3015665-node-type-4.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
StatusFileSize
new 3015665-node-type-6.patch2.86 KB

The last submitted patch, 13: 3015665-node-type-5.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Status: Needs review » Needs work

The last submitted patch, 15: 3015665-node-type-6.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs work » Needs review
StatusFileSize
new 3015665-node-type-7.patch3.05 KB
pasan.gamage’s picture

pasan.gamage commented
Status: Needs review » Reviewed & tested by the community
pasan.gamage’s picture

pasan.gamage commented

Thanks @larowlan
Will push this to next stable release.

  • pasan.gamage committed 3e26e1d on 8.x-1.x 
    Issue #3015665 by larowlan, pasan.gamage, Eric115: Add support for node-...
pasan.gamage’s picture

pasan.gamage commented
Status: Reviewed & tested by the community » Fixed
pasan.gamage’s picture

pasan.gamage commented
Status: Fixed » Closed (fixed)