FILE: /var/www/html/tolearn/modules/git/paragraphs_previewer/paragraphs_previewer.module
------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 6 LINES
------------------------------------------------------------------------------------------------
1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line
11 | ERROR | [x] Short array syntax must be used to define arrays
12 | ERROR | [x] Short array syntax must be used to define arrays
13 | ERROR | [x] Short array syntax must be used to define arrays
37 | ERROR | [x] Namespaced classes/interfaces/traits should be referenced with use statements
42 | ERROR | [x] Namespaced classes/interfaces/traits should be referenced with use statements
------------------------------------------------------------------------------------------------

FILE: /var/www/html/tolearn/modules/git/paragraphs_previewer/paragraphs_previewer.libraries.yml
-----------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------
19 | ERROR | [x] Expected 1 newline at end of file; 0 found
-----------------------------------------------------------------------------------------------

FILE: /var/www/html/tolearn/modules/git/paragraphs_previewer/src/Controller/ParagraphsPreviewController.php
-----------------------------------------------------------------------------------------------------------
FOUND 7 ERRORS AND 3 WARNINGS AFFECTING 10 LINES
-----------------------------------------------------------------------------------------------------------
3 | ERROR | [x] Namespaced classes, interfaces and traits should not begin with a file doc comment
18 | WARNING | [x] Unused use statement
19 | WARNING | [x] Unused use statement
46 | ERROR | [ ] Type hint "array" missing for $element_parents
53 | ERROR | [x] Short array syntax must be used to define arrays
83 | ERROR | [x] Short array syntax must be used to define arrays
94 | ERROR | [ ] Parameter $form_entity is not described in comment
140 | ERROR | [x] Data types in @param tags need to be fully namespaced
144 | ERROR | [x] Data types in @param tags need to be fully namespaced
175 | WARNING | [x] There must be no blank line following an inline comment
-----------------------------------------------------------------------------------------------------------

FILE: /var/www/html/tolearn/modules/git/paragraphs_previewer/src/Plugin/Field/FieldWidget/InlineParagraphsPreviewerWidget.php
-----------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 7 WARNINGS AFFECTING 7 LINES
-----------------------------------------------------------------------------------------------------------------------------
6 | WARNING | [x] Unused use statement
7 | WARNING | [x] Unused use statement
8 | WARNING | [x] Unused use statement
9 | WARNING | [x] Unused use statement
10 | WARNING | [x] Unused use statement
11 | WARNING | [x] Unused use statement
12 | WARNING | [x] Unused use statement
-----------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/tolearn/modules/git/paragraphs_previewer/src/Plugin/Field/FieldWidget/ParagraphsPreviewerWidgetTrait.php
----------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AND 3 WARNINGS AFFECTING 6 LINES
----------------------------------------------------------------------------------------------------------------------------
5 | WARNING | [x] Unused use statement
10 | WARNING | [x] Unused use statement
11 | WARNING | [x] Unused use statement
130 | ERROR | [x] Data types in @param tags need to be fully namespaced
144 | ERROR | [x] Data types in @param tags need to be fully namespaced
150 | ERROR | [x] Short array syntax must be used to define arrays
----------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/tolearn/modules/git/paragraphs_previewer/src/Plugin/Field/FieldWidget/ParagraphsPreviewerWidget.php
-----------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 7 WARNINGS AFFECTING 7 LINES
-----------------------------------------------------------------------------------------------------------------------
6 | WARNING | [x] Unused use statement
7 | WARNING | [x] Unused use statement
8 | WARNING | [x] Unused use statement
9 | WARNING | [x] Unused use statement
10 | WARNING | [x] Unused use statement
11 | WARNING | [x] Unused use statement
12 | WARNING | [x] Unused use statement
-----------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/tolearn/modules/git/paragraphs_previewer/paragraphs_previewer.theme.inc
-------------------------------------------------------------------------------------------
FOUND 3 ERRORS AND 4 WARNINGS AFFECTING 7 LINES
-------------------------------------------------------------------------------------------
1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line
7 | WARNING | [x] Unused use statement
8 | WARNING | [x] Unused use statement
9 | WARNING | [x] Unused use statement
21 | ERROR | [ ] Type hint "array" missing for $variables
29 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters
32 | ERROR | [x] Short array syntax must be used to define arrays
-------------------------------------------------------------------------------------------

CommentFileSizeAuthor
#2 3008256-coding-standard-2.patch10.53 KBdeepanker_bhalla

Comments

deepanker_bhalla created an issue. See original summary.

deepanker_bhalla’s picture

Status: Active » Needs review
StatusFileSize
new10.53 KB

Fixed the reported issues.

msankhala’s picture

Status: Needs review » Reviewed & tested by the community

@deepanker_bhalla Good work. I can confirm the patch #2 is applying cleanly and fixing all the coding standard reported by the PHPCS. Here is the output:

❯ paragraphs_previewer 8.x-1.x* git apply -v 3008256-coding-standard-2.patch
Checking patch paragraphs_previewer.libraries.yml...
Checking patch paragraphs_previewer.module...
Checking patch paragraphs_previewer.theme.inc...
Checking patch src/Controller/ParagraphsPreviewController.php...
Checking patch src/Plugin/Field/FieldWidget/InlineParagraphsPreviewerWidget.php...
Checking patch src/Plugin/Field/FieldWidget/ParagraphsPreviewerWidget.php...
Checking patch src/Plugin/Field/FieldWidget/ParagraphsPreviewerWidgetTrait.php...
Applied patch paragraphs_previewer.libraries.yml cleanly.
Applied patch paragraphs_previewer.module cleanly.
Applied patch paragraphs_previewer.theme.inc cleanly.
Applied patch src/Controller/ParagraphsPreviewController.php cleanly.
Applied patch src/Plugin/Field/FieldWidget/InlineParagraphsPreviewerWidget.php cleanly.
Applied patch src/Plugin/Field/FieldWidget/ParagraphsPreviewerWidget.php cleanly.
Applied patch src/Plugin/Field/FieldWidget/ParagraphsPreviewerWidgetTrait.php cleanly.

❯ paragraphs_previewer 8.x-1.x* phpcs --standard=Drupal .

❯ paragraphs_previewer 8.x-1.x*

PHPCS is reporting no coding standard warning after applying the patch #2.

recrit’s picture

Status: Reviewed & tested by the community » Fixed

Committed with updates for latest changes in dev with #3031262: Typo in field widget ID committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.