Incompatible with webform 8.x-5.0-rc22

patch at #2 applies cleanly and resolves this issue for me.

Looks like they've yet again changed the constructor in the latest version.

I've attached a new patch incorporating the changes from the old patch here, plus the new changes.

The patch from #2 applies fine in combination with Webform 8.x-5.1 and resolves the issue.

I feel this should at least be major. Thanks for reporting, and glad to see tests are catching it at the HEAD.

Release notes for 5.0-rc22: https://www.drupal.org/project/webform/releases/8.x-5.0-rc12

Webform is itself already working on 5.2 though...

Here's a go at this against webform 8.x-5.x

Looks like on d.org ci its installing drupal/webform (5.1.0), which makes sense since that is the recommended version at the moment.

That said, it also has a BC breaking change in the WebformSubmissionStorage constructor so we should fix that here for now.

Once webform 5.2 stable is released we'll have to revisit this.

Opened up #3037909: 5.1 and 5.2 break backwards compatibilty on the webform issue queue.

OK now we just seem to be missing schemas for test_wizard_encryption:
webform.webform.test_wizard_encryption:settings.form_login missing schema, webform.webform.test_wizard_encryption:settings.form_login_message missing schema, webform.webform.test_wizard_encryption:settings.submission_login missing schema, webform.webform.test_wizard_encryption:settings.submission_login_message missing schema

On #2943879: How to display alternate text when the user is not allowed to create a Webform ? they changed these configurations so our exported test webform needs updating. See webform_update_8143()

Thanks all!

Follow up to update the version constraint in the composer.json

Just to update the status here, the maintainer of webform module was kind enough to fix the new BC breaking change on 5.2 (see #3037909: 5.1 and 5.2 break backwards compatibilty), which is great.

It also means we should be safe with the update to composer.json proposed on #19.

Just checking it locally:

➜  drupal8 git:(2880152) ✗ composer require "drupal/webform:>=5.0.0-rc22"
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 1 install, 0 updates, 0 removals
  - Installing drupal/webform (5.1.0): Downloading (100%)

If I install with this condition, we would get 5.1.0 for new projects and for existing installs with < 5.0.0-rc22, would update to 5.1.0 and existing installs with higher versions (e.g. 5.0.0-rc23) would stay same.

I agree we should not force existing sites to upgrade to webform 1.0, and using >=5.0.0-rc22 if an existing site is requiring exactly the 5.0.0-rc22 version of webform, it would not throw a requirements error.

Thanks, @Manuel Garcia