According to Drupal standards, modules should include dependencies in the .info.yml file.
Dependencies should be namespaced in the format {project}:{module}, where {project} is the project name as it appears in the Drupal.org URL (e.g. drupal.org/project/views) and {module} is the module's machine name.
https://www.drupal.org/docs/8/creating-custom-modules/let-drupal-8-know-...
Patch to follow, thanks!

CommentFileSizeAuthor
#5 3004745-dependency-review.png20.96 KBL2G2
#2 jw_player-info-3004745-2.patch346 bytesalonaoneill

Comments

alonaoneill created an issue. See original summary.

alonaoneill’s picture

alonaoneill commented
Assigned: alonaoneill » Unassigned
Status: Active » Needs review
StatusFileSize
new jw_player-info-3004745-2.patch346 bytes

I uploaded a patch that corrects the dependency namespacing in the .info.yml file.
Thanks!

Status: Needs review » Needs work

The last submitted patch, 2: jw_player-info-3004745-2.patch, failed testing. View results

alonaoneill’s picture

alonaoneill commented
Status: Needs work » Needs review

Patch works for me.
Please review.
Thanks

L2G2’s picture

L2G2
she/her
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 3004745-dependency-review.png20.96 KB

RTBC - formatting and spacing look good to go.

  • Berdir committed 38ac65f on 8.x-1.x 
    Issue #3004745 by alonaoneill, L2G2: Dependency namespacing in .info.yml...
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Reviewed & tested by the community » Fixed

Doesn't apply anymore but reapplied the one line that still matters by hand.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.