Problem/Motivation

When all items in a child tree are disabled, the "edit children" does not appear.

Proposed resolution

This was fixed in a fork on github in this commit:
https://github.com/tomvoes/bigmenu/commit/96b2ed80ed7835bbdfa0e7cf4f2898...

Remaining tasks

Add patch. Review. Test.

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#3 bigmenu-disabled-children-show-link-3004571-3.patch3.91 KBidebr
#3 interdiff-2-3.txt3.32 KBidebr
#3 3004571-3-test-only.patch1.69 KBidebr
#2 bigmenu-disabled-children-show-link-3004571-2.patch1.41 KBaskibinski

Comments

askibinski created an issue. See original summary.

askibinski’s picture

askibinski commented
Status: Active » Needs review
StatusFileSize
new bigmenu-disabled-children-show-link-3004571-2.patch1.41 KB

Note: This patch applies to 1.x-dev#7fc1798486339bb84d83d1fbc680a71e304ce38d

idebr’s picture

idebr commented
StatusFileSize
new 3004571-3-test-only.patch1.69 KB
new interdiff-2-3.txt3.32 KB
new bigmenu-disabled-children-show-link-3004571-3.patch3.91 KB
  1. Added a test showcasing the current failing behavior
  2. Added a reference to the Drupal core issue identifying the gap in the current API: #2302149: Performance improvement by adding has_any_children column?
  3. Renamed menuLinkHasChildren to hasAnyChildren in line with the suggested API addition in #2302149: Performance improvement by adding has_any_children column?
  4. Updated code style

The last submitted patch, 3: 3004571-3-test-only.patch, failed testing. View results

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs review » Reviewed & tested by the community

That seems like a great fix, thank you @idebr and @askibinski!

  • acbramley committed 266a1bf on 8.x-1.x authored by idebr 
    Issue #3004571 by idebr, askibinski: Show the "edit children" link when...
acbramley’s picture

acbramley commented
Status: Reviewed & tested by the community » Fixed

Thanks for the patch everyone!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.