In admin/modules the description for xmlsitemap appears as 'No description available'
Pretty sure is because # is used as comment instead of semicolon ; in info file.
This may also influence functionality as the rest of the lines below '#' character seems to be ignored.
git commit -m 'Issue #3003888 by Dave Reid, VicOnt, saurabh-chugh, RenatoG: '\''No description available'\'' appears modules list' --author="davereid "

Comments

VicOnt created an issue. See original summary.

VicOnt’s picture

VicOnt’s picture

Issue summary: View changes
VicOnt’s picture

Status: Active » Needs review
saurabh-chugh’s picture

StatusFileSize
new336 bytes

@vicOnt You are correct. I think it better if we remove this comment.

renatog’s picture

Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new39.86 KB
new46.88 KB

I checked and really makes sense.

Before

After

Good catch @VicOnt

  • RenatoG committed 2f2d958 on 7.x-2.x authored by VicOnt
    Issue #3003888 by VicOnt, saurabh-chugh, RenatoG: 'No description...
renatog’s picture

Status: Reviewed & tested by the community » Fixed
Issue tags: -Adds missing preposition to description in .info file.

Committed to the dev branch.

@saurabh-chugh: Thank you for your review.

But this comment should exist for phpcs.

Best

dave reid’s picture

Status: Fixed » Needs review
StatusFileSize
new628 bytes

Why not just also fix the coding standard violations? I don't see any reason to list the files that don't contain classes, so this was a valid fix.

dave reid’s picture

StatusFileSize
new671 bytes

(I say this also as the person who apparently added those files[] listing back during the original port in 2010, my bad).

This also adds robotstxt as a test_dependency so that we can get that test running again on the testbot.

The last submitted patch, 9: 3003888-fix-info-files-unneeded.patch, failed testing. View results

Status: Needs review » Needs work

The last submitted patch, 10: 3003888-fix-info-files-unneeded.patch, failed testing. View results

dave reid’s picture

Status: Needs work » Needs review
StatusFileSize
new672 bytes

  • Dave Reid committed 208282a on 7.x-2.x
    Issue #3003888 by Dave Reid: Fixed coding standards in xmlsitemap.info...
dave reid’s picture

Issue summary: View changes
Status: Needs review » Fixed

Committed #13 to 7.x-2.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.