Config_installer crashes during the site installation with

Error: Call to undefined method Drupal\config_selector\DecoratingConfigInstaller::getSourceStorage() in /var/www/docroot/core/lib/Drupal/Core/Extension/ModuleInstaller.php on line 133 #0 /var/www/docroot/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php(83): Drupal\Core\Extension\ModuleInstaller->install(Array, false)

The method is called by the ModuleInstaller:133 but not implemented by DecoratingConfigInstaller because the method is not part of the interface. I created a patch which adds the method #3001159 and this patch simple implements the method.

CommentFileSizeAuthor
#2 get_source_storage-3001168.patch480 byteschristian.wiedemann

Comments

Christian.wiedemann created an issue. See original summary.

christian.wiedemann’s picture

christian.wiedemann commented
StatusFileSize
new get_source_storage-3001168.patch480 bytes
christian.wiedemann’s picture

christian.wiedemann commented
Status: Active » Needs review
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

@Christian.wiedemann I'm guessing you're installing from configuration as the service decoration only exists during installation. The patch looks great apart from 

+++ b/src/DecoratingConfigInstaller.php
@@ -66,6 +66,13 @@ class DecoratingConfigInstaller implements ConfigInstallerInterface {
+  /**
+   * {@inheritdoc}
+   */

No docs to inherit!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs review » Fixed

I've copied the docs from ConfigInstaller. I decided not to add a test due to the complexity of setting up a configuration install for this.

christian.wiedemann’s picture

christian.wiedemann commented

@alexpott From my point of view the method should also be part of the interface. See https://www.drupal.org/project/drupal/issues/3001159 This is the reason for @inheritdoc. But not 100% sure here

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.