Problem/Motivation

If an error occurs during the preg_replace() function a WSOD may occur. This seems to be especially true for pages with a lot of HTML. I ran into a PREG_JIT_STACKLIMIT_ERROR error code (failure due to limited JIT stack space) under those conditions.

Proposed resolution

Check for an error before setting the minified HTML since un-minified HTML is better than no HTML at all.

CommentFileSizeAuthor
#2 check-for-preg-replace-error-3000443-2.patch689 bytesdaniel korte

Comments

Daniel Korte created an issue. See original summary.

daniel korte’s picture

daniel korte
he/him/his
Primary language English
Location Brooklyn, NY
commented
Assigned: daniel korte » Unassigned
Status: Active » Needs review
StatusFileSize
new check-for-preg-replace-error-3000443-2.patch689 bytes
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Priority: Normal » Major
Status: Needs review » Reviewed & tested by the community

LGTM!

daniel korte’s picture

daniel korte
he/him/his
Primary language English
Location Brooklyn, NY
commented

Thanks, Wim!

  • slydevil committed 428aab5 on 8.x-1.x authored by Daniel Korte 
    Issue #3000443 by Daniel Korte: Only use minified HTML if there was not...
slydevil’s picture

slydevil commented
Status: Reviewed & tested by the community » Fixed
slydevil’s picture

slydevil commented
Status: Fixed » Closed (fixed)