/** @todo: Handle dev releases (compare to branch) */

Trying to resolve this todo

CommentFileSizeAuthor
#8 2994161-8.patch1.58 KBjoelpittet
#6 2994161-6-dev-version.patch1.38 KBjoelpittet
#2 2994161-2.patch1.28 KBjoelpittet

Comments

joelpittet created an issue. See original summary.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Active » Needs review
StatusFileSize
new 2994161-2.patch1.28 KB
webflo’s picture

webflo commented

Hi, sorry i did not see you patch. This needs a reroll/rewrite after the move to gitlab. I fixed the current code over in #3048140: Update diff URLs to git.drupalcode.org

webflo’s picture

webflo commented
Status: Needs review » Fixed
webflo’s picture

webflo commented
Status: Fixed » Needs work
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs work » Needs review
StatusFileSize
new 2994161-6-dev-version.patch1.38 KB

@webflo Here's a reroll, it was kinda doing what I intended before.

webflo’s picture

webflo commented 
+++ b/composer_deploy.module
@@ -64,11 +64,17 @@ function composer_deploy_preprocess_update_project_status(&$variables) {
+      $currentVersion = 'refs/tags/' . $variables['project']['existing_version'];

Is the ref/tags syntax supported on gitlab?

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
StatusFileSize
new 2994161-8.patch1.58 KB

@webfl, Gitlab is a bit finicky but you're right it doesn't have that refs/tags bit. Here's a patch that is better and easier to read and a bit more tested.

  • joelpittet committed 72b6222 on 8.x-1.x 
    Issue #2994161 by joelpittet, webflo: Fix diff link for dev versions
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs review » Fixed

I've committed this, it's a bit better than what we had and we can always revert or improve if need be.

Just getting a release out for composer 2.0 sake

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.