Currently the three subscriber classes repeat certain code parts. We can reduce this duplication with an abstract parent class.

CommentFileSizeAuthor
#3 interdiff.txt5.63 KBnagy.balint
#3 reduce-duplication-2992734-3.patch13.09 KBnagy.balint
#2 reduce-duplication-2992734-2.patch10.96 KBnagy.balint

Comments

nagy.balint created an issue. See original summary.

nagy.balint’s picture

nagy.balint commented
Status: Active » Needs review
StatusFileSize
new reduce-duplication-2992734-2.patch10.96 KB
nagy.balint’s picture

nagy.balint commented
StatusFileSize
new reduce-duplication-2992734-3.patch13.09 KB
new interdiff.txt5.63 KB

Removed constants.

  • nagy.balint committed 4be0455 on 8.x-2.x 
    Issue #2992734 by nagy.balint: Reduce code duplication with an abstract...
nagy.balint’s picture

nagy.balint commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.