Hi There,

Creating a follow up issue for #2991514 - "Why/When to use option: "Disable the system breadcrumbs"".

In this issue, it is mentioned that the checkbox "Disable the system breadcrumbs", makes the system default breadcrumb disappear in the theme layer as to not get duplicate breadcrumbs.

However, this option also be makes the the breadcrumb disappear on the admin theme. As a site builder, i should not have to add the easy breadcrumb block to the admin theme to use the module (when admin theme is different).

After looking at other issues in the queue, this issue #2990803: Config Option: Applies to administration pages, it seems to be getting at a similar issue.

Attached is a patch, is sets the the admin theme breadcrumb to NOT be affected by default.

CommentFileSizeAuthor
#9 d7-stop-module-from-disabling-admin-theme-breadcrumb-2992695-9.patch4.05 KBtatarbj
#2 d7-stop-module-from-disabling-admin-theme-breadcrumb-2992695.patch3.78 KBsilverham

Comments

silverham created an issue. See original summary.

silverham’s picture

silverham commented
StatusFileSize
new d7-stop-module-from-disabling-admin-theme-breadcrumb-2992695.patch3.78 KB
greg boggs’s picture

greg boggs
he/him
Primary language English
Location Portland Oregon
commented

Thank you!

tatarbj’s picture

tatarbj
Primary language Hungarian
Location Brussels
commented
Assigned: Unassigned » tatarbj
Category: Bug report » Feature request
Status: Active » Needs review

Hi @silverham,
thanks for opening this follow-up, let me assign it to myself and change the category as it seems a little bit of requesting a new functionality (of like a backport from the referenced d8 issue).
I'll test it and get back to you soon!
Bests,
Balazs.

Status: Needs review » Needs work

The last submitted patch, 2: d7-stop-module-from-disabling-admin-theme-breadcrumb-2992695.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

silverham’s picture

silverham commented
Issue summary: View changes

Thanks! It is a bit of new functionality, or fixes existing broken code. In any case, looking forward to the addition soon! :-)
Cheers!
Joshua.

silverham’s picture

silverham commented

Any movement on this? The D8 issue has now been set to reviewed and tested. #2990803: Config Option: Applies to administration pages

tatarbj’s picture

tatarbj
Primary language Hungarian
Location Brussels
commented
Priority: Normal » Major

Sorry everyone, this issue got totally lost - I'm going to test it in the coming days and make the commit in case of having everything good :)
Bests,
Balazs.

tatarbj’s picture

tatarbj
Primary language Hungarian
Location Brussels
commented
Status: Needs work » Needs review
StatusFileSize
new d7-stop-module-from-disabling-admin-theme-breadcrumb-2992695-9.patch4.05 KB

A bit of a clean-up and having the html variable back as it was before - i haven't find any reason to not do it and also not sure wouldn't it open a vulnerability if the variable is not set. Also updated the README.md with the new functionality and removed the TODOs as they are already in the module.

  • tatarbj committed a086812 on 7.x-2.x 
    Issue #2992695 by silverham, tatarbj: [D7] Stop module from disabling...
tatarbj’s picture

tatarbj
Primary language Hungarian
Location Brussels
commented
Status: Needs review » Fixed

Thanks everyone, this is committed now!

tatarbj’s picture

tatarbj
Primary language Hungarian
Location Brussels
commented
Status: Fixed » Closed (fixed)
silverham’s picture

silverham commented

Awesome, Thanks @tatarbj !