Problem/Motivation

The Testing profile's override of locale.settings.yml was never updated for #1998088: Convert locale_translate_english variable to CMI and #2907863: Prefer HTTPS protocol over HTTP when fetching translations.

Proposed resolution

Update the file so that the only override vs. the module-shipped config is import_enabled: false.

CommentFileSizeAuthor
#2 2988960-2.patch822 byteststoeckler

Comments

tstoeckler created an issue. See original summary.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Status: Active » Needs review
Related issues: +#2031175: Translation imports take a lot of time in tests even when not needed, +#1998088: Convert locale_translate_english variable to CMI, +#2907863: Prefer HTTPS protocol over HTTP when fetching translations
StatusFileSize
new 2988960-2.patch822 bytes

Here we go.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Version: 8.9.x-dev » 9.1.x-dev
Issue tags: +Bug Smash Initiative

Patch applies cleanly to 9.1.x.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented

Thanks for the issue and patch.

1) Confirmed that patch changes:

default_server_pattern

so that it's like #2907863: Prefer HTTPS protocol over HTTP when fetching translations

2) Confirmed that patch changes:

translate_english

so it's like #1998088: Convert locale_translate_english variable to CMI

3) Compared core/profiles/testing/config/optional/locale.settings.yml and core/modules/locale/config/install/locale.settings.yml and the only difference is import_enabled:

13c13
<   import_enabled: false
---
>   import_enabled: true

4) Patch covers the issue summary.

5) Kicked off tests for 9.1.x. If those pass, seems RTBC to me.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Status: Needs review » Needs work

Tests failed for 9.1.x. Back to needs work.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented

That was a random failure in line 180 of EntityReferenceWidgetTest::testWidget():

"Bear" was found but shouldn't be there.
Failed asserting that a boolean is not empty.

Marking RTBC per #6.5

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Status: Needs work » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: 9.1.x-dev » 8.9.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed cb2b75344a to 9.1.x and 0ce998a243 to 9.0.x and 5fbd535c71 to 8.9.x. Thanks!

diff core/profiles/testing/config/optional/locale.settings.yml core/modules/locale/config/install/locale.settings.yml                                                                                                                                  Tue 14 Jul 14:24:42 2020
13c13
<   import_enabled: false
---
>   import_enabled: true

Still true.

Backported to 8.9.x to keep all the test stuff aligned.

  • alexpott committed cb2b753 on 9.1.x 
    Issue #2988960 by tstoeckler, Kristen Pol: Testing profile's locale....

  • alexpott committed 0ce998a on 9.0.x 
    Issue #2988960 by tstoeckler, Kristen Pol: Testing profile's locale....

  • alexpott committed 5fbd535 on 8.9.x 
    Issue #2988960 by tstoeckler, Kristen Pol: Testing profile's locale....

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.