Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.I’ve found that the file removal in VersioncontrolGitRepositoryManagerWorkerDefault::reInit() doesn’t actually remove files. I expect the shell expansion of the …/{one,two} is not happening with how the command is executed.
This ends up leaving promoted sandboxes with the sandbox config and hooks.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 2985905.patch | 951 bytes | drumm |
Comments
Comment #2
drummThis patch simplifies this to be a less-clever rm in a loop. It may not be efficient, but it doesn’t need to be. And it is more-readable code.
Comment #4
marvil07 commented@drumm, thanks for the report and the patch here.
You are right, the shell expansion is not working.
escapeshellarg()was sourrounding the generated string in quotes, including the parenthesis, and therefore invalidating the shell expansion.This can also be fixed by adding a bit more logic, but I agree with simplifying the code expanding it a little.
As mentioned in the last comment, it is easier to read after the changes, and the performance gain from possible change should not be considerable, so I added the change here to 7.x-1.x.