Add submodule for token support

@Scheepers de Bruin: Thank you, this is a great idea and nice patch. Is it possible to use entities instead of nodes?
That would make it "the Drupal 8 way" and support all kind of entities (Taxonomies, Users, ECK, custom ...) perhaps we can have a look at other modules which solve this?

I'll have a look as soon as possible. If someone has the time earlier, please create an entity patch.

PS: #2 works perfectly for nodes, thank you!

RTBC. As said in #3 it would make sense to extend this on all kind of entities (the Drupal 8 way ;))

Reverting my RTBC... markup field can be used in any kind of entity, so we should ensure all entity types / parent entity type to be handled as tokens.

Patch attached. Please test and review.

Removed one unrequired line.

Another fix.

The question is now... does the same make sense for the widget? Some tokens might be empty on "create" while they are available on edit...

I just tested the patch in #9 and it's a nice little solution for me, works with an ECK entity.

As for the question you pose, whether it makes sense due to some tokens being empty on "create"? Yes, that is a problem, but there are always tokens that have various issues being populated due to context, node / entity ids being notorious examples.

My thoughts are, tokens are something that probably need better explanations for end-users and are more of a site-builder tool ( though some may disagree ). While it's probably something the token module should handle, I think this can be easily mitigated with some simple text like:

Tokens are allowed, but keep in mind, not all tokens are available in every context. Please consult the module / token provider for more details.

My thoughts are, tokens are something that probably need better explanations for end-users and are more of a site-builder tool

Well, markup field is for sitebuilders, isn't it? The end-user simply sees the replaced token.

Tokens are allowed, but keep in mind, not all tokens are available in every context. Please consult the module / token provider for more details.

No, there won't be support by the module maintainers. It's open source.

But what we might add is the token browser and a link to the token explanation like in other places. Feel free to create a modified patch. Furthermore I'm not sure if we should check for permissions?

After thinking about this for some time, I think this should be separated into a sub-module. The functionality is not needed in many cases and can be an alternative or addition to markup_twig, which is also a separate module. Issues like #3052621: Allow empty markup field show that this may also have impact on things like validation or rendering.

Thank you Anybody,

Patch #9 saved me! Now I can use tokens with markup module. That is amazing!

Lovin' this - thank you!

I am working to Add submodule for token support.

Hi Anybody, I have added a submodule for token support.

Please review.

Thanks
Samit K.

@samit.310@gmail.com please provide this as MR. Thanks!

Hi @Anybody,

MR is created please review and merge.

https://git.drupalcode.org/project/markup/-/merge_requests/5

Thanks
Samit K

Just tried #18 and the MR5, and they didn't work. (nothing happened) I'm using D10.
using 'drupal/markup:^2.0@beta'