Need to update manage interface for 8.x version and realize it via entity list builder.

Known problems:
- Problems with weights value on drag & drop action
- Ignoring entities load limits for 8.x, need to add limits and pager
- - As case: #2314945-9: Pager on node ordering display not needed

CommentFileSizeAuthor
#2 manage_interface-2969001-2.patch19.05 KBdavps

Comments

david.pashaev created an issue. See original summary.

davps’s picture

Status: Active » Needs review
StatusFileSize
new19.05 KB

Some comments:

nodeorder.routing.yml:

nodeorder.admin_order:
  /* ... */
  defaults:
    _controller: 

We can't use _entity_list in route, because we are displaying custom nodes list. Extending and modify contrib NodeListBuilder is a bad solution, here.

NodeOrderListBuilder.php:

  /**
   * {@inheritdoc}
   */
  protected function getEntityIds() {
    /* ... */

    return $this->nodesWeight ? array_keys($this->nodesWeight) : [-1];
  }

Method load will be triggered later, if we pass empty array as an argument, method will be load all entities with type node, will be passed -1 as an allowed ID for node to prevent loading all entities. Case for term without nodes.

Additional changes:

- Added custom access to route
- Rewrited few methods and functions
- Old form removed
- Added pager, to avoid problems with too many entities #2314945-9: Pager on node ordering display not needed
- Added columns: Type, Status, Operations

  • david.pashaev committed d7b445a on 8.x-1.x
    Issue #2969001 by david.pashaev: Manage order interface
    
davps’s picture

Assigned: davps » Unassigned
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.