Value Conflict with Layout Builder

+1

Raising to critical as I also experienced the problem and it makes saving the manage display not workable at all.

Patch fixes the error, but it looks like the tests don't pass, so we we need to make sure everything still works of course.

Let's see what this does.

fix assert in clonetest

I'm a moron.

Also enabled layout builder in all tests so we know for sure nothing gets in the way.

Interesting. Let's see if everything is fine without enabling layout_builder.

I would also argue that we drop the test for Field Layout, that module is pretty much obsolete anyway.

Ok, now again with layout_builder enabled.

Looks like field layout won't be gone yet, so keeping that one as well.

Note, field layout problem might be related to #2931226: Enabling core Field layout module fatals during installation

Ok the other failure is because of layout_builder_entity_view_alter() remove our extra fields which are added in hook_entity_view().

I'd argue that this is a bug in layout builder as it should check whether the entity that is being rendered is actually using a layout builder configuration. That should speed up everything too imo.

Opened #2993298: layout_builder_entity_view_alter() should check whether layout builder configuration is used

Thanks for the patch, I applied the patch on last dev version and its work for the first save, after that if I save the display I get this error

Error: Cannot use string offset as an array in /modules/contrib/ds/includes/field_ui.inc on line 371 #0 [internal function]: ds_field_ui_layouts_save(Array, Object(Drupal\Core\Form\FormState))

Hmm, yeah, we're getting this too now, in combination with layout builder restrictions module.

New patch attached which fixes that.

It sounds like new major version should be released cos form structure changes

+++ b/tests/src/Functional/TestBase.php
@@ -38,6 +38,7 @@ abstract class TestBase extends BrowserTestBase {
+    'layout_builder',

does it makes sense to enable the module for all tests?

Closed #3023924: An error occurs in Views when attempting to add an exposed filter by ID with the 'Allow multiple selections' option enabled as a duplicate issue
NW since it is failing tests, and for #25

Committed the patch without the layout_builder tests enabled.

It sounds like new major version should be released cos form structure changes

That seems a bit to disruptive. Core doesn't follow that practice either, so not bumping for now. Not many modules alter back on the form after DS has done it's stuff, so I think we're fine here.

Raising to normal to keep track of #2993298: layout_builder_entity_view_alter() should check whether layout builder configuration is used - once that is in, we need to add a test with layout builder enabled.

Actually, created a follow up at #3029785: Add test with layout builder

Resetting critical status.