Problem/Motivation
In #2966856: Hide and disable Drupal Migrate Multilingual we keep the Migrate Drupal Multilingual module around for backwards compatibility reasons. Since it is only a shell module to compartmentalize expeirmental multilingual migrations, once it gets stable, it should be removed.
Proposed resolution
Remove in Drupal 9 once we don't need to provide this module anymore. The migrations themselves will all be kept.
And catch pointed out that the update update function added in #2208401: [META] Remaining multilingual migration paths must be removed and that may be handled by #2942096: [policy, no patch] Remove old update hooks prior to each major version (Drupal 10 and later).
Remaining tasks
Do it in Drupal 9.
User interface changes
The module will be gone.
API changes
None.
Data model changes
None.
Release notes snippet
The Migrate Drupal Multilingual module is now removed.
| Comment | File | Size | Author |
|---|---|---|---|
| #31 | 2966859-31.patch | 1.33 KB | andypost |
| #29 | 2966859-29.patch | 1.33 KB | andypost |
Comments
Comment #4
gábor hojtsyComment #5
gábor hojtsyComment #6
quietone commentedComment #8
gábor hojtsyWill be removed in Drupal 10.
Comment #11
gábor hojtsyParenting to the right place.
Comment #12
longwaveI opened #3261957: Properly deprecate migrate_drupal_multilingual for future removal before I found this to use the new module deprecation mechanism in 9.4.x, not sure it's really needed.
Here is a patch to simply remove this module in 10.0.x.
Comment #14
longwaveNeeds #3261957: Properly deprecate migrate_drupal_multilingual for future removal first to clean up references to the module.
Comment #15
andypostDependency committed
Comment #16
ravi.shankar commentedAdded reroll of patch #12.
These files are already removed.
Comment #17
longwaveComment #18
andypostHope it will be grean
Comment #20
spokjePHP 8.1 + MySQL 5.6 came back green, confident the other tests will return green as well.
If not TestBot will kick this back to Needs Work.
Comment #21
catchCommitted 91e4364 and pushed to 10.0.x. Thanks!
Comment #23
andypostHere''s follow-up to remove it from composer replace section for core
Comment #24
catchThe diff is a lot bigger than I'd expect - composer version maybe?
Comment #25
xjmUsing Composer 2.2.6 (the latest version), my diff looks like this:
That's from updating
core/composer.jsonand then runningInterestingly, the lockfile hash looks identical to @andypost's patch.
Comment #26
andypostThat's because after updating core/composer.json I need to
update --lockComment #27
xjmI also cannot reproduce @andypost's version of the patch using Composer 1.10, either. 🤔
Comment #28
xjmAh, crosspot. I can reproduce it if I run
composer update --lockafter theCOMPOSER_ROOT_VERSION=10.0.x-dev composer update drupal/coreusing Composer 2.2.6, but only after explicitly typing the command separately. It was my understanding thatcomposer update --lockwas no longer preferred since it won't update templates and metapackages when needed, and it no longer is in our handbook instructions for that reason. That would explain the divergence, because the last person (or the tagging script) also probably just did theCOMPOSER_ROOT_VERSION=10.0.x-dev composer update drupal/core. Edit: It is worth noting though that the key bits, the file hashes and the references to the module, are the same between my version and @andypost's.Comment #29
andypost@xjm thanks! Using
COMPOSER_ROOT_VERSION=10.0.x-dev composer update drupal/corethe patch is much cleanerPS I'm using composer 2.2.6
Comment #30
catchLooks good now.
Comment #31
andypostre-roll after #3188858: Remove the entity_reference module entirely on the Drupal 10 branch
Comment #33
xjmCommitted the hotfix to 10.0.x. Thanks!
Comment #34
xjmAlso added the module to:
https://www.drupal.org/about/core/policies/core-change-policies/deprecat...
Module and theme removals should always be tagged for the release notes. Thanks!