Problem/Motivation

In #2966856: Hide and disable Drupal Migrate Multilingual we keep the Migrate Drupal Multilingual module around for backwards compatibility reasons. Since it is only a shell module to compartmentalize expeirmental multilingual migrations, once it gets stable, it should be removed.

Proposed resolution

Remove in Drupal 9 once we don't need to provide this module anymore. The migrations themselves will all be kept.
And catch pointed out that the update update function added in #2208401: [META] Remaining multilingual migration paths must be removed and that may be handled by #2942096: [policy, no patch] Remove old update hooks prior to each major version (Drupal 10 and later).

Remaining tasks

Do it in Drupal 9.

User interface changes

The module will be gone.

API changes

None.

Data model changes

None.

Release notes snippet

The Migrate Drupal Multilingual module is now removed.

Comments

heddn created an issue. See original summary.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

gábor hojtsy’s picture

Title: PP-1: Follow-up: remove migrate_drupal_i18n » [PP-1] Remove Migrate Drupal Multilingual module in Drupal 9
Version: 8.8.x-dev » 9.x-dev
Issue summary: View changes
Issue tags: +Drupal 9
gábor hojtsy’s picture

quietone’s picture

Issue summary: View changes

Version: 9.x-dev » 9.0.x-dev

The 9.0.x branch will open for development soon, and the placeholder 9.x branch should no longer be used. Only issues that require a new major version should be filed against 9.0.x (for example, removing deprecated code or updating dependency major versions). New developments and disruptive changes that are allowed in a minor version should be filed against 8.9.x, and significant new features will be moved to 9.1.x at committer discretion. For more information see the Allowed changes during the Drupal 8 and 9 release cycles and the Drupal 9.0.0 release plan.

gábor hojtsy’s picture

Title: [PP-1] Remove Migrate Drupal Multilingual module in Drupal 9 » Remove Migrate Drupal Multilingual module in Drupal 10
Version: 9.0.x-dev » 9.1.x-dev
Issue tags: -Drupal 9 +Drupal 10

Will be removed in Drupal 10.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

gábor hojtsy’s picture

longwave’s picture

Status: Postponed » Needs review
StatusFileSize
new2.68 KB

I opened #3261957: Properly deprecate migrate_drupal_multilingual for future removal before I found this to use the new module deprecation mechanism in 9.4.x, not sure it's really needed.

Here is a patch to simply remove this module in 10.0.x.

Status: Needs review » Needs work

The last submitted patch, 12: 2966859-12.patch, failed testing. View results

longwave’s picture

Status: Needs work » Postponed

Needs #3261957: Properly deprecate migrate_drupal_multilingual for future removal first to clean up references to the module.

andypost’s picture

Status: Postponed » Needs work

Dependency committed

ravi.shankar’s picture

StatusFileSize
new639 bytes

Added reroll of patch #12.
These files are already removed.

core/modules/migrate_drupal_multilingual/migrate_drupal_multilingual.install
core/modules/migrate_drupal_multilingual/migrate_drupal_multilingual.install
longwave’s picture

Status: Needs work » Needs review
andypost’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: +Deprecation Removal

Hope it will be grean

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 16: 2966859-16.patch, failed testing. View results

spokje’s picture

Status: Needs work » Reviewed & tested by the community

PHP 8.1 + MySQL 5.6 came back green, confident the other tests will return green as well.
If not TestBot will kick this back to Needs Work.

catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed 91e4364 and pushed to 10.0.x. Thanks!

  • catch committed 91e4364 on 10.0.x
    Issue #2966859 by longwave, ravi.shankar, heddn, quietone: Remove...
andypost’s picture

Status: Fixed » Needs review
StatusFileSize
new6.64 KB

Here''s follow-up to remove it from composer replace section for core

catch’s picture

The diff is a lot bigger than I'd expect - composer version maybe?

xjm’s picture

Using Composer 2.2.6 (the latest version), my diff looks like this:

diff --git a/composer.lock b/composer.lock
index aef64aa592..995e3f073b 100644
--- a/composer.lock
+++ b/composer.lock
@@ -448,7 +448,7 @@
             "dist": {
                 "type": "path",
                 "url": "core",
-                "reference": "231d26e39bada8a65354596fd06da9d68e402440"
+                "reference": "616ed878be16e5b265beb990b9e5b658950821d0"
             },
             "require": {
                 "asm89/stack-cors": "^2.0.2",
@@ -572,7 +572,6 @@
                 "drupal/menu_ui": "self.version",
                 "drupal/migrate": "self.version",
                 "drupal/migrate_drupal": "self.version",
-                "drupal/migrate_drupal_multilingual": "self.version",
                 "drupal/migrate_drupal_ui": "self.version",
                 "drupal/minimal": "self.version",
                 "drupal/mysql": "self.version",
diff --git a/core/composer.json b/core/composer.json
index 3f41631c6a..210fbfd0d0 100644
--- a/core/composer.json
+++ b/core/composer.json
@@ -126,7 +126,6 @@
         "drupal/menu_ui": "self.version",
         "drupal/migrate": "self.version",
         "drupal/migrate_drupal": "self.version",
-        "drupal/migrate_drupal_multilingual": "self.version",
         "drupal/migrate_drupal_ui": "self.version",
         "drupal/mysql": "self.version",
         "drupal/node": "self.version",

That's from updating core/composer.json and then running

COMPOSER_ROOT_VERSION=10.0.x-dev composer update drupal/core

Interestingly, the lockfile hash looks identical to @andypost's patch.

andypost’s picture

That's because after updating core/composer.json I need to update --lock

xjm’s picture

I also cannot reproduce @andypost's version of the patch using Composer 1.10, either. 🤔

xjm’s picture

Ah, crosspot. I can reproduce it if I run composer update --lock after the COMPOSER_ROOT_VERSION=10.0.x-dev composer update drupal/core using Composer 2.2.6, but only after explicitly typing the command separately. It was my understanding that composer update --lock was no longer preferred since it won't update templates and metapackages when needed, and it no longer is in our handbook instructions for that reason. That would explain the divergence, because the last person (or the tagging script) also probably just did the COMPOSER_ROOT_VERSION=10.0.x-dev composer update drupal/core. Edit: It is worth noting though that the key bits, the file hashes and the references to the module, are the same between my version and @andypost's.

andypost’s picture

StatusFileSize
new1.33 KB

@xjm thanks! Using COMPOSER_ROOT_VERSION=10.0.x-dev composer update drupal/core the patch is much cleaner

PS I'm using composer 2.2.6

catch’s picture

Status: Needs review » Reviewed & tested by the community

Looks good now.

andypost’s picture

  • xjm committed 68b7585 on 10.0.x
    Issue #2966859 hotfix by andypost, xjm, catch: Remove the self.version...
xjm’s picture

Status: Reviewed & tested by the community » Fixed

Committed the hotfix to 10.0.x. Thanks!

xjm’s picture

Issue tags: +10.0.0 release notes

Also added the module to:
https://www.drupal.org/about/core/policies/core-change-policies/deprecat...

Module and theme removals should always be tagged for the release notes. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.