file_save_data() should replace exported files if they exist. That's more of an edge case, but if one of job items creation failed, editors are not able to save/add new translation jobs.

I will attach the patch that fixes both issues, in the first comment

CommentFileSizeAuthor
#3 2965856.patch1020 bytesvalthebald

Comments

valthebald created an issue. See original summary.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

#2878086: Download link for XLIFF file opens file instead of downloading it. was about fixing the first part?

valthebald’s picture

valthebald
Location Sofia
commented
Title: File translator should suggest to download html files » File translator should replace job item files if they exist
Issue summary: View changes
StatusFileSize
new 2965856.patch1020 bytes

Wow, that was quick! :) Thanks @Berdir, indeed I used version 1.3 where it wasn't fixed yet. Here's the patch that fixes the second part

valthebald’s picture

valthebald
Location Sofia
commented
valthebald’s picture

valthebald
Location Sofia
commented
Status: Active » Needs review

  • Berdir committed 3b3c171 on 8.x-1.x authored by valthebald 
    Issue #2965856 by valthebald: File translator should replace job item...
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Makes sense, was wondering about tests but we currently don't hardcode the filename in the tests, and while we could add a dummy file already there, I think it's not really worth it for that special case.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.