Problem/Motivation

If no items are selected in the tree, the modal window for 'Delete' still opens with a confusing message:

Please select the terms you want to delete.

No buttons appear on the modal, and the user must press X to close it.

Proposed resolution

Options:

  • Ideally : Delete would not be clickable (or visible) unless an item is checked. This may not be simple with FancyTree.
  • Alternative : Improve message and add button to close modal.
CommentFileSizeAuthor
#6 confusing-delete-button-behaviour-2960820-04.patch1.35 KBmirom

Comments

JacobSanford created an issue. See original summary.

jacobsanford’s picture

jacobsanford
Primary language English
Location Fredericton 🇨🇦
commented
Title: Button behaviour for actions » Confusing action button behaviour
jacobsanford’s picture

jacobsanford
Primary language English
Location Fredericton 🇨🇦
commented
Title: Confusing action button behaviour » Confusing Delete button behaviour
mirom’s picture

mirom commented

If none of the items are selected then button is disabled, otherwise it's enabled. Check git here http://g.recordit.co/LLw4dnRfVG.gif

mirom’s picture

mirom commented
Status: Active » Needs review
mirom’s picture

mirom commented
StatusFileSize
new confusing-delete-button-behaviour-2960820-04.patch1.35 KB

  • JacobSanford committed 87c9f60 on 8.x-1.x authored by mirom 
    Issue #2960820 by mirom: Confusing Delete button behaviour
jacobsanford’s picture

jacobsanford
Primary language English
Location Fredericton 🇨🇦
commented
Status: Needs review » Fixed

Hi @mirom, thanks for the contribution! I ran into a bit of a problem with the select callback not firing, but it turned out to be one of my Chrome extensions.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.