Currently the constructor of SvgImageFormatter uses the LoggerChannel object instead of the LoggerInterface. Therefore I created this patch that makes it more general to also allow different loggers.

CommentFileSizeAuthor
#2 use_logger_interface-2954559-2.patch1.77 KBtimkruijsen

Comments

timKruijsen created an issue. See original summary.

timkruijsen’s picture

timkruijsen commented
StatusFileSize
new use_logger_interface-2954559-2.patch1.77 KB
pdenooijer’s picture

pdenooijer commented
Status: Needs review » Reviewed & tested by the community

Seems like a good change!
Dependency inversion principle

imyaro’s picture

imyaro commented
Assigned: Unassigned » imyaro

  • zvse committed 1fdd679 on 8.x-1.x authored by timKruijsen 
    Issue #2954559 by timKruijsen, pdenooijer, zvse: Use logger interface to...
imyaro’s picture

imyaro commented
Status: Reviewed & tested by the community » Fixed

Yes, change is pretty good. Applied.

pdenooijer’s picture

pdenooijer commented

Nice :)!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

svenryen’s picture

svenryen commented

The fix in this issue was reverted by #2941795: Uninstalling module wipes out unrelated display configs.. See #3008518: Issue #2941795 reverted the code fix in #2954559 (LoggerInterface) for a fix.