Problem/Motivation

When sorting open revisions RevisionTreeIndex does a sort based on the revision hash. This is an ascii sort on the string, therefore 10-abc is less than 9-abc. This is not what we need.

Proposed resolution

Sort by the ID before the -, then by the whole hash.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#5 interdiff.txt15.94 KBtimmillwood
#4 2954537-4.patch34.3 KBtimmillwood
#4 2954537-4-test-only.patch33.24 KBtimmillwood
#2 2954537-2.patch1.06 KBtimmillwood

Comments

timmillwood created an issue. See original summary.

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
commented
StatusFileSize
new 2954537-2.patch1.06 KB
timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
commented
Status: Active » Needs review
Issue tags: +Needs tests
timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
commented
Issue tags: -Needs tests
StatusFileSize
new 2954537-4-test-only.patch33.24 KB
new 2954537-4.patch34.3 KB
timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
commented
Assigned: timmillwood » Unassigned
StatusFileSize
new interdiff.txt15.94 KB

Here's a rough interdiff without the noise of moving a webtest to a browser test.

timmillwood credited jeqq.

timmillwood credited vijay85.

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
commented

timmillwood credited vijaycs85.

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
commented

  • timmillwood committed 9fa386b on 8.x-1.x 
    Issue #2954537 by timmillwood, jeqq, vijaycs85: Revision tree sorting...
timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.