Hi all,

I was working on a project and noticed that, if I do not provide any keys, an HTTP request is sent to google API.

Debugging

Problem/Motivation

According to Geocoding Developer's Guide, one of the required parameters in a geocoding request is an API key, or even client ID and digital signature for premium users. That means no request should be sent to google API without any of those parameters.

Proposed resolution

I do not know much about the conception of this module but, the way it is structured, it seems that it will not be worth to remove the empty option from the authentication method select box, since it is possible to use different third-party services other than google API. I propose that we check if the key/client ID is set right before building the URL to make the request and trigger an watchdog error in case none of those parameters were provided.

Remaining tasks

N/A.

User interface changes

N/A.

API changes

N/A.

Data model changes

N/A.

CommentFileSizeAuthor
#11 geocoder-google-request-without-key-2954088-11.patch1.46 KBhmdnawaz
#8 geocoder-google-request-without-key-2954088-8.patch2.2 KBhmdnawaz
#7 geocoder-google-request-without-key-2954088-7.patch1.26 KBhmdnawaz
#6 geocoder-google-request-without-key-2954088-6.patch1.16 KBnoman_297
#3 geocoder-google_request_without_key-2954088-7.patch1.43 KBGuillhermm
request_debug.png19.23 KBGuillhermm

Comments

Guillhermm created an issue. See original summary.

Guillhermm’s picture

Guillhermm commented
Issue summary: View changes
Guillhermm’s picture

Guillhermm commented
StatusFileSize
new geocoder-google_request_without_key-2954088-7.patch1.43 KB
Guillhermm’s picture

Guillhermm commented
Status: Active » Needs review
diego_mow’s picture

diego_mow commented
Status: Needs review » Reviewed & tested by the community

Patch from comment #3 tested and works fine.
TRBC.

noman_297’s picture

noman_297 commented
Version: 7.x-1.3 » 7.x-1.4
Assigned: Unassigned » noman_297
StatusFileSize
new geocoder-google-request-without-key-2954088-6.patch1.16 KB

Patch in comment #3 is updated for 7.x-1.4 line numbers are changed in version 7.x-1.4.

hmdnawaz’s picture

hmdnawaz commented
StatusFileSize
new geocoder-google-request-without-key-2954088-7.patch1.26 KB

Rerolled the patch for version 7.x-1.4

hmdnawaz’s picture

hmdnawaz commented
StatusFileSize
new geocoder-google-request-without-key-2954088-8.patch2.2 KB
hmdnawaz’s picture

hmdnawaz commented
Assigned: noman_297 » Unassigned
itamair’s picture

itamair commented
Status: Reviewed & tested by the community » Needs work

this need reroll and new review

hmdnawaz’s picture

hmdnawaz commented
StatusFileSize
new geocoder-google-request-without-key-2954088-11.patch1.46 KB

Rerolled the patch for version 1.5

hmdnawaz’s picture

hmdnawaz commented
Status: Needs work » Needs review

  • itamair committed f443059 on 7.x-1.x authored by hmdnawaz 
    Issue #2954088 by hmdnawaz, Guillhermm, noman_297: Requests are sent to...
itamair’s picture

itamair commented
Status: Needs review » Fixed

thanks @hmdnawaz
Finally committed into dev, I am going to deploy a new 7.x-1.6 release with this ...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.