The Date Time enhancer (\Drupal\jsonapi_extras\Plugin\jsonapi\FieldEnhancer\DateTimeFromStringEnhancer) only supports one date value.
I know that there is a rework of enhancers on the 8.x-2.x branch. Looking at it, this can be ported there as well with minimal effort.

CommentFileSizeAuthor
#11 jsonapi_extras-date-range-fields-support-2953227-d8-11.patch2.52 KBndobromirov
#10 jsonapi_extras-date-range-fields-support-2953227-d8-10.patch2.41 KBndobromirov
#2 datetime-range-support.2953227.2.patch1.4 KBvtcore

Comments

vtcore created an issue. See original summary.

vtcore’s picture

vtcore commented
StatusFileSize
new datetime-range-support.2953227.2.patch1.4 KB

Patch suggestion.

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
Status: Active » Needs review
e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented

Thanks for the patch. Kicking off tests.

vtcore’s picture

vtcore commented

Tests seem to pass. Can you commit to the 1.x branch?

  • e0ipso committed 5d80d63 on 8.x-1.x authored by vtcore 
    Issue #2953227 by vtcore: Date Time enhancer does not work with Date...
e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
Version: 8.x-1.x-dev » 8.x-2.x-dev
Status: Needs review » Active

Fixed for 1.x (unsupported), now opening for 2.x.

  • e0ipso committed c7a91cc on 8.x-1.x 
    Revert "Issue #2953227 by vtcore: Date Time enhancer does not work with...
e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented

:-( I had to revert this commit because this is breaking the JSON Schema for these fields, while trying to port it to 2.x.

Take a look at getJsonSchema in DateTimeEnhancerBase.

ndobromirov’s picture

ndobromirov commented
Status: Active » Needs review
StatusFileSize
new jsonapi_extras-date-range-fields-support-2953227-d8-10.patch2.41 KB

Hi here is an attempt to have the schema correct with the string / array of strings variation.

ndobromirov’s picture

ndobromirov commented
StatusFileSize
new jsonapi_extras-date-range-fields-support-2953227-d8-11.patch2.52 KB

Here is another iteration of the patch that now I was able to test and schema validation passes on date range fields.

  • ndobromirov authored 5837e8d on 8.x-3.x 
    Issue #2953227 by ndobromirov, vtcore, e0ipso: Date Time enhancer does...
e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
Status: Needs review » Fixed

Thanks for this contribution! Sorry it took so long to get it merged.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

andsigno82’s picture

andsigno82 commented

Hi, have to reopen this. using the 3.x-dev version.
the enhancer still return this error when you select either datetime or timestamp

AH01071: Got error 'PHP message: TypeError: DateTime::__construct() expects parameter 1 to be string, array given in /contenta/web/core/lib/Drupal/Component/Datetime/DateTimePlus.php