Noticed in #2951191: Fixing test fails and various cleanup, a long time ago we added the timestamp to have the verbose list but that seems wrong, we should not be grouping by timestamp, that doesn't make sense like that. That means it will only count hits that happened in the same second as the sensor value.

CommentFileSizeAuthor
#2 image-style-timestamp-2951222-2.patch2.67 KBberdir

Comments

Berdir created an issue. See original summary.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Needs review
StatusFileSize
new image-style-timestamp-2951222-2.patch2.67 KB

This removes the timestamp field in getAggregateQuery(), instead, I added a MAX(timestamp) just for the verbose output as we only need it there.

  • Berdir committed e16a3e2 on 8.x-1.x 
    Issue #2951222 by Berdir: ImageMissingStyleSensorPlugin incorrectly...
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Committed. I'm pretty sure that this change makes sense.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.