No backend implementation for Calculate in EOD report

This was working, we should add a test for it as well so it doesn't break again in the future.

Any chance of a test for this fix? As per #2. Also does this only fix for js-enabled browsers or everyone?

The report has two buttons - Calculate and Close Register & Save.

Pressing Calculate saves stuff, which is surprising since it's the button that says it wont save.

It looks like Calculate should show calculated values only, but not save them.

This patch addresses issue #6.

#7 changes the message that's shown but it doesn't actually stop saving, so it has the same issue.

An issue introduced in #7 is that it compares the translated version of 'Update Report' or 'Calculate' against the static values 'Update Report' or 'Calculate'.

It also no longer states that the values were saved when doing Close Register & Save instead of Update Report.

Created a new submit for the calculate button that rebuilds the form using the "Declared Amount" values in $form_state.

Calculate doesn't play nicely with the Cash Deposit, sometimes the deposit doesn't seem to update and then even if I hit calculate it is still stuck.

Fixed deposit calculations.

This still needs tests. The patch #13 is working.

+++ b/modules/reports/src/Form/EndOfDayForm.php
@@ -275,7 +294,10 @@ class EndOfDayForm extends FormBase {
+            '#validate' => ['::endOfDaySaveValidate'],

This callback is empty. Do we still need it?

This is incomplete.

Re-rolled the patch, added a ajax callback for calculate button and fed the formstate values to 'results' method for populating the results table.

Rerolled patch.

The payment types need to be dynamic and not hardcoded, see the other parts of the report for how they are loaded dynamically.

I went ahead and rewrote the for loop for the calculate button, and removed the calculateSubmit function in favour of the new ajaxRefresh() method. I removed the message for when values are calculated since it doesn't appear until the page is refreshed (probably because it's not a submit type and doesn't refresh the page itself?). Also re-added the test which went missing in a reroll and verified it works properly, while adding a few other asserts.

This patch is just held up on some insufferable config issue with a new field from commerce, I'll fix that and then this can be merged in.