Problem/Motivation

If the media update runs first then the revision_default field is installed incorrectly.

Proposed resolution

Update the dependency, obviously we can only commit this after 8.5.0 is out, including then depending on it.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#6 media_entity-8.5.x-update-2947520-6.patch1.27 KBberdir
#2 media_entity-8.5.x-update-2947520-2.patch1023 bytesberdir

Comments

Berdir created an issue. See original summary.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Needs review
StatusFileSize
new media_entity-8.5.x-update-2947520-2.patch1023 bytes

Status: Needs review » Needs work

The last submitted patch, 2: media_entity-8.5.x-update-2947520-2.patch, failed testing. View results

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Version: 8.x-1.x-dev » 8.x-2.x-dev
Status: Needs work » Needs review
berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Bump, 8.5.0 is out, time to get this in :)

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
StatusFileSize
new media_entity-8.5.x-update-2947520-6.patch1.27 KB

Also added the core dependency to info.yml, untested but copied from a working example. Not sure it will make a difference as media_entity is already installed, but maybe new drush versions will complain.

marcoscano’s picture

marcoscano
Primary language Portuguese, Brazil
Location Barcelona, Spain
commented
Status: Needs review » Reviewed & tested by the community

Thanks @Berdir !

Performed a quick manual test and didn't see any side effect. IMHO we are good to go.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented 
+++ b/media_entity.install
@@ -552,12 +552,15 @@ function _media_entity_snapshot_config(array $names, $delete = FALSE) {
+  // Ensure that system_update_8402() is aware of the media entity type, which is

The tiniest nitpick, fixable on commit -- this line is 81 characters long.

Otherwise, looks good to me. +1 RTBC.

  • marcoscano committed 4f41ced on 8.x-2.x authored by Berdir 
    Issue #2947520 by Berdir, marcoscano, phenaproxima: media_entity update...
marcoscano’s picture

marcoscano
Primary language Portuguese, Brazil
Location Barcelona, Spain
commented
Status: Reviewed & tested by the community » Fixed

Fixed that and committed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.