The title says it all. Example: https://soundcloud.com/sandra-oupas/sets/francais

Currently the track_id is required, so it won't work when a playlist is in used.

CommentFileSizeAuthor
#6 spider.gif5.26 MBshadcn
#4 2945759-soundcloud-playlists.patch4.87 KBjcisio

Comments

jcisio created an issue. See original summary.

shadcn’s picture

shadcn commented

@jcisio would you like to co-maintain the module? I don't think I will have time to work on new features. Let me know.

jcisio’s picture

jcisio commented
Assigned: Unassigned » jcisio

I'm working on this issue.

@arshacdn I'd love to. I'm working on this module to make it work on Drupal 8.4 and 8.5, so I'll have time to maintain it at least in the near future.

jcisio’s picture

jcisio commented
Status: Active » Needs review
StatusFileSize
new 2945759-soundcloud-playlists.patch4.87 KB

This patch adds playlists support. I remove track_id from the template because it is not used in the template, only in the preprocess function, so not really BC-break.

jcisio’s picture

jcisio commented

There is room for improvement:

- Separate playlist into another source. I'm not sure if it is useful.
- Otherwise, add an option to have different embed height when it is a track and when it is a playlist.

But it worths a separate issue. Now just get the core feature in first.

shadcn’s picture

shadcn commented
StatusFileSize
new spider.gif5.26 MB

@jcisio You're up. I added you as a maintainer. Feel free to test and commit the patches. Thank you.

spidey

  • jcisio committed a85d306 on 8.x-2.x 
    Issue #2945759 by jcisio: Support playlist
jcisio’s picture

jcisio commented
Version: 8.x-1.x-dev » 8.x-2.x-dev
Status: Needs review » Fixed

@arshadcn Thank you.

This patch was tested by my colleague. So, committed and pushed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.