Backport Accept.js support to 7.x branch

Proof of concept backport. Basics work with minor testing.

Does modifying these variables still work when using this patch/using Accept.js?

It is not modifying the existing payment method. It is adding a new one, so emulators need not worry.

RE bug in #11: that is a fix I just had to make in D8 #2832501: Duplicate payment profile code should lookup if method is already in system.

ericchew thanks so much. I'm going to tackle the "Invalid OTS Token" error.

This backports the profile creation logic from D8 to handle Accept.js and invalid tokens.

+++ b/js/commerce_authnet.form.js
@@ -0,0 +1,48 @@
+      var $form = $('.acceptjs-form').closest('form');
+      $form.removeOnce('acceptjs-processed');
+      $form.off('submit.authnet');
+      debugger;

Debugging line, and invalid jQuery for what ships with core.

Fixed jQuery

Interdiff:

diff --git a/js/commerce_authnet.form.js b/js/commerce_authnet.form.js
index fa91351..5b28c90 100644
--- a/js/commerce_authnet.form.js
+++ b/js/commerce_authnet.form.js
@@ -22,7 +22,7 @@
     detach: function (context, settings) {
       var $form = $('.acceptjs-form').closest('form');
       $form.removeOnce('acceptjs-processed');
-      $form.off('submit.authnet');
+      $form.unbind('submit.authnet');
       debugger;
     }
   };

I also hit another quirk. If there is an error the submit button is still disabled and the loading gif keeps on spinning.

Fixes unable to go back on error (or at all.)

diff --git a/js/commerce_authnet.form.js b/js/commerce_authnet.form.js
index 5b28c90..c0038c3 100644
--- a/js/commerce_authnet.form.js
+++ b/js/commerce_authnet.form.js
@@ -18,12 +18,19 @@
       // else if (authnetSettings.paymentMethodType === 'authnet_echeck') {
       //  Drupal.commerceAuthorizeNetEcheckForm($form, authnetSettings);
       // }
+
+      // AcceptJS hijacks all submit buttons for this form. Simulate the back
+      // button to make sure back submit still works.
+      $('.checkout-cancel, .checkout-back').bind('mousedown, click', function(e) {
+        debugger;
+        e.preventDefault();
+        window.history.back();
+      });
     },
     detach: function (context, settings) {
       var $form = $('.acceptjs-form').closest('form');
       $form.removeOnce('acceptjs-processed');
       $form.unbind('submit.authnet');
-      debugger;
     }
   };
   Drupal.commerceAuthorizeNet = {

Here's an attempt to fix duplicates in card on file / admin terminal scenario.

When using the card 4111111111111111 with zip code 46282 the General bank decline workflow is triggered.

However checkout completes, and the order's payment transaction shows success even though:

{
  "transactionResponse": {
    "responseCode": "2",
    "authCode": "",
    "avsResultCode": "Y",
    "cvvResultCode": "P",
    "cavvResultCode": "2",
    "transId": "60103295060",
    "refTransID": "",
    "transHash": "AD657D03593ADA3A3A8702A6D0019126",
    "testRequest": "0",
    "accountNumber": "XXXX1111",
    "accountType": "Visa",
    "errors": [
      {
        "errorCode": "2",
        "errorText": "This transaction has been declined."
      }
    ],
    "transHashSha2": ""
  },
  "refId": "ref1526327925",
  "messages": {
    "resultCode": "Ok",
    "message": [
      {
        "code": "I00001",
        "text": "Successful."
      }
    ]
  }
}

Fix the handling.

Interdiff:

diff --git a/includes/commerce_authnet.acceptjs.inc b/includes/commerce_authnet.acceptjs.inc
index f04ef6d..49cbbd9 100644
--- a/includes/commerce_authnet.acceptjs.inc
+++ b/includes/commerce_authnet.acceptjs.inc
@@ -265,6 +265,24 @@ function commerce_authnet_acceptjs_submit_form_submit($payment_method, $pane_for
     commerce_payment_transaction_save($transaction);
     return FALSE;
   }
+  elseif (!empty($result['transactionResponse']['errors'])) {
+    $transaction->status = COMMERCE_PAYMENT_STATUS_FAILURE;
+    $transaction_message = array();
+    foreach ($result['transactionResponse']['errors'] as $message) {
+      $transaction_message[] = t('Authorize.net error: @code - @error', array(
+        '@code' => $message['errorCode'],
+        '@error' => $message['errorText'],
+      ));
+      watchdog('commerce_authnet', 'Authorize.net error: @code - @error', array(
+        '@code' => $message['errorCode'],
+        '@error' => $message['errorText'],
+      ), WATCHDOG_ERROR);
+      $transaction->message = implode('<br />', $transaction_message);
+      drupal_set_message(check_plain($message['errorText']), 'error');
+    }
+    commerce_payment_transaction_save($transaction);
+    return FALSE;
+  }
 
   // Set the transaction status based on the type of transaction this was.
   switch ($payment_method['settings']['txn_type']) {

Clean up the files.

+++ b/includes/commerce_authnet.acceptjs.inc
@@ -0,0 +1,736 @@
+  if (!empty($order)) {
+    if (isset($order->commerce_customer_billing)) {
+      $request['createTransactionRequest']['transactionRequest']['billTo'] = commerce_authnet_cim_billto_array($order);
+    }
+    if (isset($order->commerce_customer_shipping)) {
+      $request['createTransactionRequest']['transactionRequest']['shipTo'] = commerce_authnet_cim_shipto_array($order);
+    }
+  }

I think the only thing we are missing from the AIM gateway is:

* Invoice num
* Email
* Customer ID
* Customer IP

  // Add additional transaction invormation to the request array.
  $nvp += array(
    // Order Information
    'x_invoice_num' => $order->order_number,
    'x_description' => substr(implode(', ', $description), 0, 255),

    // Customer Information
    'x_email' => substr($order->mail, 0, 255),
    'x_cust_id' => substr($order->uid, 0, 20),
    'x_customer_ip' => substr(ip_address(), 0, 15),
  );

Let's commit this. I discussed with drumm, and this looks to be solid! Thanks a lot. We can handle any nits in follow ups.

Yay! Glad to see this in.