In PHP 7.1, during feature reverts (and perhaps other times too), there is an error "PHP Fatal error: Only variables can be passed by reference".

CommentFileSizeAuthor
#2 views_timelinejs-remove_value_pass_by_reference-2936352-2-D7.patch1.21 KBliam morland

Comments

Liam Morland created an issue. See original summary.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Active » Needs review
StatusFileSize
new views_timelinejs-remove_value_pass_by_reference-2936352-2-D7.patch1.21 KB
liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Issue tags: +php7.1
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs review » Reviewed & tested by the community

I don't think the unset() is needed, but thanks for the patch

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

The unset() makes no functional difference, besides freeing an insignificant amount of memory. It does make it clear to readers of the code that the variable is not used again.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Issue tags: -php7.1 +PHP 7.1

  • dcam committed fb34bce on 7.x-1.x authored by Liam Morland 
    Issue #2936352 by Liam Morland, joelpittet: Fix PHP 7.1 compatibility by...
dcam’s picture

dcam commented
Status: Reviewed & tested by the community » Fixed

I committed #2. Thank you @Liam Morland, also @joelpittet for reviewing it.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.