[youtube] tagged videos were showing up as empty boxes on my web page. The attached patch fixes that and adds the gesture attribute Youtube is putting in their embed code.

CommentFileSizeAuthor
#4 xbbcode-2930533-4.patch660 bytescburschka
xbbcode_basic_fix_youtube_link.patch597 bytesmdesimone

Comments

mdesimone created an issue. See original summary.

cburschka’s picture

cburschka
they
commented
Version: 7.x-1.7 » 7.x-1.x-dev
Status: Active » Needs review
cburschka’s picture

cburschka
they
commented
Status: Needs review » Needs work

Patch should be relative to the module directory

cburschka’s picture

cburschka
they
commented
Status: Needs work » Needs review
StatusFileSize
new xbbcode-2930533-4.patch660 bytes

  • cburschka committed c15cffe on 7.x-1.x authored by mdesimone 
    Issue #2930533 by mdesimone, cburschka: Youtube tags should use HTTPS...
cburschka’s picture

cburschka
they
commented
Status: Needs review » Fixed

Thanks very much for your work!

mdesimone’s picture

mdesimone commented

Patch should be relative to the module directory

Whoops! I just uploaded the output of my `git diff`. This is my first time posting a patch to a Drupal module.

cburschka’s picture

cburschka
they
commented

Yeah, `git diff` is always relative to the repository (which I guess is the site in your case). When you create a patch, the best way to do it is to clone the module itself (`git clone https://git.drupal.org/project/*`) and make the changes in there. :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.