Signature of SocialAuthUserManager::authenticateUser changed

CommentFileSizeAuthor
#14 2925056-13.patch12.69 KBgvso
#12 2925056-12.patch12.07 KBgvso
#10 interdiff-2925056-9-10.txt4.37 KBgvso
#10 2925056-10.patch12.07 KBgvso
#9 2925056-9.patch7.57 KBgvso
#2 social_auth_twitter-migrate-to-new-social-auth-2925056-0.patch1.13 KBshmel210

Comments

shmel210 created an issue. See original summary.

shmel210’s picture

shmel210 commented
Status: Needs work » Needs review
StatusFileSize
new social_auth_twitter-migrate-to-new-social-auth-2925056-0.patch1.13 KB

Status: Needs review » Needs work

The last submitted patch, 2: social_auth_twitter-migrate-to-new-social-auth-2925056-0.patch, failed testing. View results

shmel210’s picture

shmel210 commented
Status: Needs work » Needs review
gvso’s picture

gvso
Primary language Spanish
commented

Hi!

The signature changed. However, this patch was created for Social Auth Twitter 1.x which depends on Social Auth 1.x

shmel210’s picture

shmel210 commented

Please, can you provide example how it shoud be done. I dont know how create branch at patch.

gvso’s picture

gvso
Primary language Spanish
commented

Well, a patch can not do that. Since Twitter does not fully use OAuth 2, there is not a reliable library from The League yet. I guess we should initially update Social Auth Twitter 1.x as it is now and make it compatible with Social Auth 2.x.

I have created a branch for 8.x-2.x, so you can test your changes there.

gvso’s picture

gvso
Primary language Spanish
commented
Version: 8.x-1.x-dev » 8.x-2.x-dev
gvso’s picture

gvso
Primary language Spanish
commented
Title: Migrate to social_auth 8.x-2.0 » Migrate to Social Auth 2.x
StatusFileSize
new 2925056-9.patch7.57 KB

This is a working 'port'

gvso’s picture

gvso
Primary language Spanish
commented
StatusFileSize
new 2925056-10.patch12.07 KB
new interdiff-2925056-9-10.txt4.37 KB

Updated test file.

Status: Needs review » Needs work

The last submitted patch, 10: 2925056-10.patch, failed testing. View results

gvso’s picture

gvso
Primary language Spanish
commented
Status: Needs work » Needs review
StatusFileSize
new 2925056-12.patch12.07 KB

Status: Needs review » Needs work

The last submitted patch, 12: 2925056-12.patch, failed testing. View results

gvso’s picture

gvso
Primary language Spanish
commented
Status: Needs work » Needs review
StatusFileSize
new 2925056-13.patch12.69 KB

This should work

Status: Needs review » Needs work

The last submitted patch, 14: 2925056-13.patch, failed testing. View results

gvso’s picture

gvso
Primary language Spanish
commented
Status: Needs work » Needs review

  • gvso committed 59483aa on 8.x-2.x 
    Issue #2925056 by gvso, shmel210: Migrate to Social Auth 2.x
gvso’s picture

gvso
Primary language Spanish
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.