Problem/Motivation

Actually Media_entity tests are full RED because New deprecation strategy not support all deprecated code since 8.4.0.

That's really noisy and a real problems to follow and test if issues/patch break tests or not this is why I flag that as major.

Proposed resolution

We just need to convert deprecated code.

@see https://www.drupal.org/pift-ci-job/810366

CommentFileSizeAuthor
#2 fixe_failling_tests-2923355-2.patch1.24 KBwoprrr

Comments

woprrr created an issue. See original summary.

woprrr’s picture

woprrr commented
Status: Active » Needs review
StatusFileSize
new fixe_failling_tests-2923355-2.patch1.24 KB

This small fixe does fixe the problems.

woprrr’s picture

woprrr commented
Related issues: +#2922257: Convert ImageWidgetCropExamples Functional WebTestBase to BrowserTestBase

This related issue have a tests_dependency with media_entity. We wait this merged :)

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs review » Reviewed & tested by the community

The patch looks pretty good to me, but I don't feel like it's in my wheelhouse to actually commit it. But, it looks good. So, let's land it...

mallezie’s picture

mallezie
Primary language Dutch
Location Loenhout
commented
Title: Fixe failling tests since 8.4 » Fix failing tests since 8.4

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Thanks, everyone. Committed and pushed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.