Thanks, Joseph! Great work!

How about use breakpoints from other modules and/or themes (ie AT) and as a consequence responsive image styles?

Additional informations about it:
https://www.drupal.org/docs/8/mobile/responsive-web-design
https://www.drupal.org/docs/8/mobile-guide/responsive-images-in-drupal-8

I can be a tester.

CommentFileSizeAuthor
#8 semantic_markup-2922467-8.patch1.68 KBvvs
#7 use_system_breakpoints-2922467-7.patch518 bytesjwkovell

Comments

VVS created an issue. See original summary.

jwkovell’s picture

jwkovell commented
Assigned: Unassigned » jwkovell

I'll give that a try!

I should have something ready to test in about a week.

jwkovell’s picture

jwkovell commented

A new version (8.x-2.x-dev) has been posted that uses Drupal breakpoints.

This is a substantial change from the first version, and required abandoning any configuration you may have had in the first version.

- Crate a view
- Select "Responsive Columns" as the display format
- Click the settings link
- Specify which breakpoint group you want to use (the module includes on called "Views responsive columns")
- Specify how many columns you want for each breakpoint

The downside is that breakpoints are not in editable configuration, but it'd be fairly easy to modify the included views_responsive_columns.breakpoints.yml file as needed.

jwkovell’s picture

jwkovell commented
Status: Active » Needs review
vvs’s picture

vvs commented
Status: Needs review » Active

It's working for "Views responsive columns" breakpoints group, but use ul, li is not semantic.

If I set "at_core.simple" breakpoints group (from Adaptivetheme) displays one 100% width column for all breakpoints. Hmmmm…

jwkovell’s picture

jwkovell commented

I wonder if the "." in "at_core.simple" is breaking it. When something goes wrong, a single column is the fallback. I'll look into that.

Can you check if any other breakpoint groups without a "." work for you? You probably, for example, have a Toolbar break group.

As for the markup feedback, I tend to think of it as a "list of columns". However, I'm open to changing that if it's too far from markup standards. It's a very easy template change. Do you suggest divs, sections, or something else?

jwkovell’s picture

jwkovell commented
StatusFileSize
new use_system_breakpoints-2922467-7.patch518 bytes

Here's a patch that seems to resolve the issue with using breakpoint groups with a "." in their name.

Let me know if that fixes at_core.simple

vvs’s picture

vvs commented
StatusFileSize
new semantic_markup-2922467-8.patch1.68 KB

'Dot' problem.

Patch is not working for me. Im clear drupal and browser caches.

Semantic markup.

I added a patch.

Additional troubles.

I can't add new branches for patching. Have an error: refname '8.x-2.x' is ambiguous..

Please rename git tags with this manual, i.e 8.x-2.0-alfa1. See naming in a big modules.

git tag 8.x-2.0-alfa1 8.x-2.x
git tag -d 8.x-2.x
git push origin :refs/tags/8.x-2.x
git push --tags

Hmm. I'm studying with you. :) This is my first patch.

jwkovell’s picture

jwkovell commented

Okay, let's split this up into it's individual issues.

As for the patch. I believe only module maintainers can publish new branches, so it does not surprise me that that didn't go through. It was my bad for not following the process with the start of this issue, but I'll try to do so now.

Please create that new issue, add your patch to it, I'll CR it. Based on my review so far, everything looks great.

I hope to release an updated version of the module with both your patch and my own (once it's working and both patches have gone through CR) very soon.

Thanks :)

jwkovell’s picture

jwkovell commented
Status: Active » Fixed
Related issues: +#2924955: Support break groups that contain "." characters

Marking original issue as fixed.

Secondary issues will be handled in their own threads.

jwkovell’s picture

jwkovell commented
Status: Fixed » Closed (fixed)