Problem/Motivation

Most of the UI (router, tabs, etc) are currently hard-coded for nodes.

src/Access/WorkflowParticipantsAccessChecker.php
54:   * @todo Don't hard-code for node.

src/Form/WorkflowParticipantsForm.php
58:    // @todo Generalize this beyond nodes.
161:    // @todo Entity access to the workflow participants entity should work

src/Routing/RouteSubscriber.php
30:    // @todo This is hard-coded for nodes.
55:   * @todo Investigate decorating the node access check instead.

src/StateTransitionValidation.php
32:   * @todo Once ported to 8.3.x version of content moderation/workflow, a

src/Plugin/Block/WorkflowParticipants.php
121:    // @todo This is hardcoded for nodes.

workflow_participants.info.yml
9:  # @todo Remove hard-coded node dependency.

workflow_participants.module
69:  // @todo Don't hard code for node.

workflow_participants.routing.yml
10:# @todo Don't hard-code for nodes.

Proposed resolution

Generalize the code to work with any moderated entities.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 2920654-02.patch21.71 KBjhedstrom

Comments

jhedstrom created an issue. See original summary.

jhedstrom’s picture

Added some follow-ups for the remaining pieces.

  • jhedstrom committed 3c3b1c3 on 8.x-2.x
    Issue #2920654 by jhedstrom: Remove node hard-coding
    
jhedstrom’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.